feat: cubic Detector infrastructure #2308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Physics performance monitoring for 7e58285Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #2308 +/- ##
==========================================
- Coverage 49.31% 49.04% -0.27%
==========================================
Files 447 453 +6
Lines 25153 25411 +258
Branches 11570 11731 +161
==========================================
+ Hits 12405 12464 +59
- Misses 4558 4690 +132
- Partials 8190 8257 +67
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Conflicts to be resolved. |
|
What's the plan for this @asalzburger? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the second, rather trivial but often used Detector geometry setup, the building of telescope like detector.
Detector connection is allowed in (x,y,z,) and for arbitrarily rotated volumes.
When concentrating common code between the
CylindricalDetectorHelperand theCubicDetectorHelper, a dependency problem for thePortalHelperand its associated Json test appeared (it would not allow to to define a dummyTest::DetectorVolume, hence some of the deep dependencies have been simplified by move parts of the code into implementation files.