feat: GX2F: use magnetic field to fit q/p #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2574 +/- ##
==========================================
+ Coverage 49.57% 49.59% +0.01%
==========================================
Files 473 473
Lines 26803 26819 +16
Branches 12349 12356 +7
==========================================
+ Hits 13288 13300 +12
Misses 4752 4752
- Partials 8763 8767 +4
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
AJPfleger
changed the title
This was referenced Oct 26, 2023
paulgessinger
changed the title
paulgessinger
changed the title
andiwand
approved these changes
Nov 4, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
A new abort condition for the Global Chi Square Fitter: `relChi2changeCutOff`. Before we could only steer with `nUpdateMax` when to stop to iterate. This relative cut-off checks if the `chi2sum` already converged. TODO: detect in the unitTest, that the system stopped before reaching `nUpdateMax`. blocked by: - #2574
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
Adds more parameters to the python bindings of the Global Chi Square Filter: ``` /// Max number of iterations during the fit (abort condition) size_t nUpdateMax = 5; /// Disables the QoP fit in case of missing B-field bool zeroField = false; /// Check for convergence (abort condition). Set to 0 to skip. double relChi2changeCutOff = 1e-7; ``` blocked by: - #2574 - #2586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Global Chi Square Fitter now runs with magnetic fields.
We need the concept of different$|B| = 0$ , there would be no information for q/p, resulting in zero-entries in the matrix. Therefore, we previously removed those parts from the system. Still, we remove all time rows and columns, since we don't want to fit it yet.
const size_t reducedMatrixSize, since we have a matrix inversion during the fit process. In the case ofThis now also fixes the
loc1-pulls in Generic Detector (truth_tracking_gx2f.py). (Other pulls are not great yet.)