-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ML seed selection #2576
feat: ML seed selection #2576
Conversation
parser.add_argument( | ||
"--MLSeedFilter", | ||
help="Use the Ml seed filter to select seed after the seeding step", | ||
action="store_true", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cue my obligatory comment that I'm not a fan of just adding extra features to this script steered by command line options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't disagree and I am 100% ready to implement this any other way (but I am not sure which one)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2576 +/- ##
=======================================
Coverage 49.73% 49.73%
=======================================
Files 474 474
Lines 26872 26872
Branches 12364 12364
=======================================
Hits 13366 13366
Misses 4702 4702
Partials 8804 8804 ☔ View full report in Codecov by Sentry. |
This pull request add a ML based seed selection that can be used to reduce the number of seed after the seeding step.
This also add :