Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ML seed selection #2576

Closed

Conversation

Corentin-Allaire
Copy link
Contributor

This pull request add a ML based seed selection that can be used to reduce the number of seed after the seeding step.

This also add :

  • Performances plots based on the distance to the closest track
  • A CSV writer for seed (used in the training of the NN)
  • the option to run on GPU for the ML training script

Comment on lines +48 to +52
parser.add_argument(
"--MLSeedFilter",
help="Use the Ml seed filter to select seed after the seeding step",
action="store_true",
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cue my obligatory comment that I'm not a fan of just adding extra features to this script steered by command line options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't disagree and I am 100% ready to implement this any other way (but I am not sure which one)

@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Track Finding Ambiguity Resolution labels Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6517c35) 49.73% compared to head (fd3fc76) 49.73%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2576   +/-   ##
=======================================
  Coverage   49.73%   49.73%           
=======================================
  Files         474      474           
  Lines       26872    26872           
  Branches    12364    12364           
=======================================
  Hits        13366    13366           
  Misses       4702     4702           
  Partials     8804     8804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Corentin-Allaire Corentin-Allaire marked this pull request as draft November 17, 2023 12:34
@paulgessinger paulgessinger added this to the next milestone Dec 6, 2023
@paulgessinger paulgessinger modified the milestones: next, v32.0.0 Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants