refactor: Release step constraint after stepper in propagation

[andiwand]

This avoids cases where an actor/aborter sets a step constrained that will never be overwritten again.

I also generalize the release function and rename the set function in the stepper.

blocked by

• refactor: Intersection index for stepper surface update #2599

[github-actions]

📊: Physics performance monitoring for 723396b

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[codecov]

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (e574e8a) 49.56% compared to head (723396b) 49.54%.

Files	Patch %	Lines
Core/include/Acts/Propagator/Navigator.hpp	20.00%	4 Missing ⚠️
Core/include/Acts/Propagator/Propagator.ipp	0.00%	0 Missing and 2 partials ⚠️
.../include/Acts/Propagator/MultiEigenStepperLoop.hpp	75.00%	0 Missing and 1 partial ⚠️
Core/include/Acts/Propagator/StandardAborters.hpp	50.00%	0 Missing and 1 partial ⚠️
.../include/Acts/Propagator/detail/SteppingHelper.hpp	0.00%	0 Missing and 1 partial ⚠️
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2596      +/-   ##
==========================================
- Coverage   49.56%   49.54%   -0.02%     
==========================================
  Files         474      474              
  Lines       26930    26929       -1     
  Branches    12423    12425       +2     
==========================================
- Hits        13348    13343       -5     
- Misses       4748     4749       +1     
- Partials     8834     8837       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[paulgessinger]

Looks reasonable. There's still some CI failures at this point.

[andiwand]

did't update the reference files yet to give people a chance to look at the physmon diff. will update now

[acts-project-service]

✅ Athena integration test results [37a2f9e]

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data