refactor: Refactor SurfaceReached aborter
#2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
andiwand
changed the title
SurfaceReached aborterSurfaceReached aborter
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
==========================================
- Coverage 49.64% 49.56% -0.08%
==========================================
Files 474 474
Lines 26946 26923 -23
Branches 12415 12422 +7
==========================================
- Hits 13376 13344 -32
- Misses 4747 4750 +3
- Partials 8823 8829 +6 ☔ View full report in Codecov by Sentry. |
andiwand
added
🛑 blocked
|
there is some physmon diff for the gsf but it looks marginal to me. maybe @benjaminhuth can have a look. will not update the reference for now |
|
Seems to improve things actually, right? Maybe because the overstep limit is now properly propagated? |
…face-reached-aborter
…face-reached-aborter
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
Currently it is not possible to discover in which stage of propagation we are in the actors and aborters. By introducing a propagator stage enum, adding it to the state and setting it in the proagator loop this can be used in the actors and aborters. Pulled out of #2603
|
This does not cause any output changes in Athena. |
github-actions
bot
added
Infrastructure
benjaminhuth
approved these changes
Nov 20, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Aimed to improve consistency and split surface and volume interactions into two logical parts pulled out of #2603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes I try to decouple the navigator and surface reached aborter further. I don't believe that the navigator has to care about the target surface other than optimization reasons while the surface reached aborter should only care about the surface it is supposed to care about without looking at or touching the navigation state.
blocked by