Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Rename and rearrange propagator options #2620

Merged
merged 7 commits into from
Nov 4, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Nov 2, 2023

Discovered in #2619 that the propagator options might be misleading

@andiwand andiwand added this to the v31.0.0 milestone Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2620 (7969f14) into main (eb12644) will decrease coverage by 0.04%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
- Coverage   49.53%   49.50%   -0.04%     
==========================================
  Files         473      473              
  Lines       26763    26746      -17     
  Branches    12338    12338              
==========================================
- Hits        13257    13240      -17     
  Misses       4753     4753              
  Partials     8753     8753              
Files Coverage Δ
Core/include/Acts/Navigation/DetectorNavigator.hpp 51.44% <ø> (ø)
...lude/Acts/Propagator/DenseEnvironmentExtension.hpp 100.00% <100.00%> (ø)
Core/include/Acts/Propagator/DirectNavigator.hpp 65.04% <100.00%> (ø)
Core/include/Acts/Propagator/Navigator.hpp 57.22% <100.00%> (ø)
Core/include/Acts/Propagator/Propagator.hpp 90.62% <100.00%> (-2.06%) ⬇️
Core/include/Acts/Propagator/StandardAborters.hpp 66.03% <100.00%> (ø)
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 32.00% <ø> (ø)
Core/include/Acts/TrackFitting/KalmanFitter.hpp 41.17% <ø> (ø)
.../include/Acts/Vertexing/HelicalTrackLinearizer.ipp 26.37% <100.00%> (ø)
...nclude/Acts/Vertexing/NumericalTrackLinearizer.ipp 11.47% <100.00%> (ø)
... and 2 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@kodiakhq kodiakhq bot merged commit c578923 into acts-project:main Nov 4, 2023
53 checks passed
@github-actions github-actions bot removed the automerge label Nov 4, 2023
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 4, 2023
@andiwand andiwand deleted the refactor-propagator-options branch November 4, 2023 09:22
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants