refactor: Replace cuboid bounds with trapezoid bounds for multiwire builder #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An indexed surfaces multilayer navigation Remove unused variable Remove unused variable fix type conversions for the number of bins changes on the mockupbuilder header file and on the unit test Update Core/include/Acts/Navigation/MultiWireLayerUpdators.hpp Co-authored-by: Andreas Stefl <[email protected]> Change on test mockup builder script Multi Wire structure with the interface Changes on the multiwire structure builder Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable fix type conversions for the number of bins Multi Wire structure with the interface Delete MultiWireLayerUpdators.hpp Update CMakeLists.txt revert some files trying for Indexed Surfaces Generator Indexed Surfaces generator update fix LayerStructure builder fix fix Delete MuonChamber.gdml revert layer strucutre builder from upstream reslove conflict Multi Layer Builder cmake file Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file changes on the mockupbuilder header file and on the unit test Update Core/include/Acts/Navigation/MultiWireLayerUpdators.hpp Co-authored-by: Andreas Stefl <[email protected]> Change on test mockup builder script Multi Wire structure with the interface Changes on the multiwire structure builder Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file Multi Wire structure with the interface Delete MultiWireLayerUpdators.hpp Delete IndexedSurfacesNavigationTests.cpp Update CMakeLists.txt revert some files trying for Indexed Surfaces Generator Indexed Surfaces generator update fix LayerStructure builder fix fix Delete MuonChamber.gdml revert layer strucutre builder from upstream cmake file Update MultiWireStructureBuilder.hpp Update MultiWireStructureBuilder.hpp Update MultiWireStructureBuilder.cpp Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file changes on the mockupbuilder header file and on the unit test Update Core/include/Acts/Navigation/MultiWireLayerUpdators.hpp Co-authored-by: Andreas Stefl <[email protected]> Change on test mockup builder script Multi Wire structure with the interface Changes on the multiwire structure builder Place the files that create the mockup geometry in another folder Change the location of the gdml file An indexed surfaces multilayer navigation Remove unused variable fix type conversions for the number of bins Remove some actsvg includes not needed now change the path for the gdml file Multi Wire structure with the interface Delete MultiWireLayerUpdators.hpp Delete IndexedSurfacesNavigationTests.cpp Update CMakeLists.txt revert some files trying for Indexed Surfaces Generator Indexed Surfaces generator update LayerStructure builder fix fix Delete MuonChamber.gdml revert gdml from upstream revert layer strucutre builder from upstream fix conflicts and some optimizations conflicts and format revert some files revert some files new updator fix license issue fix
dimitra97
force-pushed
the
multiwirebuilder-refactor
branch
from
99a1bd1 to
97ae20f
Compare
dimitra97
force-pushed
the
multiwirebuilder-refactor
branch
from
b901a1b to
2216752
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
=======================================
Coverage 49.52% 49.52%
=======================================
Files 474 474
Lines 26968 26968
Branches 12452 12452
=======================================
Hits 13355 13355
Misses 4755 4755
Partials 8858 8858 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the bounds type (cuboid-->trapezoid) for the Multi Wire Structure Builder, to make it more generic and it is more suitable to use it like that in athena for the MDT chambers, where there are also trapezoidal shape ones.