refactor!: error handling in the vertexing algorithms #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for 71149e8physmon summary
|
felix-russo
changed the title
…-error-message-amvfitter
felix-russo
commented
Nov 14, 2023
felix-russo
changed the title
acts-project-service
added
the
Breaks Athena build
This reverts commit ecaa5a8.
paulgessinger
added
automerge
and removed
Breaks Athena build
andiwand
reviewed
Nov 17, 2023
Co-authored-by: Andreas Stefl <[email protected]>
paulgessinger
previously approved these changes
Nov 17, 2023
andiwand
approved these changes
Nov 17, 2023
acts-project-service
added
the
Breaks Athena build
7 tasks
github-merge-queue bot
pushed a commit
to eic/EICrecon
that referenced
this pull request
Dec 22, 2023
### Briefly, what does this PR introduce? ~~Thanks to C++20 we can now do templated lambdas which don't require syntactic validity of all code paths. That makes forward/backward compatibility across Acts versions easier with constexpr lambdas.~~ Ifdefs on defined Acts major versions allow us to bypass code blocks that are not compilable or parsable under different versions of Acts. Ref: acts-project/acts#2649 ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue: Acts v31 compatibility) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: Dmitry Kalinkin <[email protected]>
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Dec 23, 2023
### Briefly, what does this PR introduce? ~~Thanks to C++20 we can now do templated lambdas which don't require syntactic validity of all code paths. That makes forward/backward compatibility across Acts versions easier with constexpr lambdas.~~ Ifdefs on defined Acts major versions allow us to bypass code blocks that are not compilable or parsable under different versions of Acts. Ref: acts-project/acts#2649 ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue: Acts v31 compatibility) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: Dmitry Kalinkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and lets the
Finderconsume theFitterandSeedFinderconsistently by using themovesemantic. This was necessary in order to useunique_ptrs for the loggers (except for theImpactPointEstimator, which is passed to bothFinderandFitter)BREAKING CHANGE:When setting up theFinderone now needs to moveFitterandSeedFinderinto it