Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use time info in Kalman fitter and in impact point estimations #2650

Closed

Conversation

felix-russo
Copy link
Contributor

@felix-russo felix-russo commented Nov 12, 2023

same as #2544 but with useTime in AdaptiveMultiVertexFitter set to true

let's see if the physmon improves

@github-actions github-actions bot added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Vertexing labels Nov 12, 2023
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #2650 (442c363) into main (85a0fea) will increase coverage by 0.07%.
The diff coverage is 25.92%.

@@            Coverage Diff             @@
##             main    #2650      +/-   ##
==========================================
+ Coverage   49.71%   49.78%   +0.07%     
==========================================
  Files         474      473       -1     
  Lines       26859    26847      -12     
  Branches    12362    12339      -23     
==========================================
+ Hits        13352    13365      +13     
- Misses       4706     4708       +2     
+ Partials     8801     8774      -27     
Files Coverage Δ
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.hpp 73.07% <ø> (ø)
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp 45.69% <0.00%> (+0.66%) ⬆️
...nclude/Acts/Vertexing/TrackDensityVertexFinder.ipp 35.71% <0.00%> (ø)
...ore/include/Acts/Vertexing/KalmanVertexUpdater.ipp 34.45% <26.92%> (+5.88%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@felix-russo felix-russo deleted the time-fitting-with-time-ipe branch November 13, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants