Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GSF component momentum cut to stabilize fit #2661

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

update

213347c
Select commit
Loading
Failed to load commit list.
Draft

feat: Add GSF component momentum cut to stabilize fit #2661

update
213347c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 30, 2024 in 0s

49.63% (+0.00%) compared to fd1e0b4

View this Pull Request on Codecov

49.63% (+0.00%) compared to fd1e0b4

Details

Codecov Report

Attention: Patch coverage is 30.35714% with 39 lines in your changes missing coverage. Please review.

Project coverage is 49.63%. Comparing base (fd1e0b4) to head (213347c).
Report is 1059 commits behind head on main.

Files with missing lines Patch % Lines
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 30.61% 15 Missing and 19 partials ⚠️
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp 33.33% 0 Missing and 4 partials ⚠️
Core/include/Acts/TrackFitting/detail/GsfUtils.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2661   +/-   ##
=======================================
  Coverage   49.63%   49.63%           
=======================================
  Files         474      474           
  Lines       26941    26955   +14     
  Branches    12415    12418    +3     
=======================================
+ Hits        13372    13380    +8     
+ Misses       4746     4744    -2     
- Partials     8823     8831    +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov