-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve DD4hep based detector building and add tests #2689
feat: improve DD4hep based detector building and add tests #2689
Conversation
Hi @dimitra97 - since you have some DD4hep knowledge, could you have a look at this, please ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2689 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 474 474
Lines 26892 26892
Branches 12376 12376
=======================================
Hits 13368 13368
Misses 4710 4710
Partials 8814 8814 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Only a minor question just for me to understand.
Approving!
This PR adds the possibility that the internal layer structure, i.e. the contained surfaces - drive the dimension of the external volume shape.
E.g. in DD4hep, one could then write
Which will trigger measuring the internal surface dimensions in z & r and add a clearance around it.