Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve DD4hep based detector building and add tests #2689

Merged
merged 6 commits into from
Nov 17, 2023

Conversation

asalzburger
Copy link
Contributor

This PR adds the possibility that the internal layer structure, i.e. the contained surfaces - drive the dimension of the external volume shape.

E.g. in DD4hep, one could then write

      <argument value="acts_volume_internals_measure: str = z,r"/>
      <argument value="acts_volume_internals_clearance: double = pix_b_clear"/>

Which will trigger measuring the internal surface dimensions in z & r and add a clearance around it.

@asalzburger asalzburger added this to the next milestone Nov 17, 2023
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Nov 17, 2023
@asalzburger
Copy link
Contributor Author

Hi @dimitra97 - since you have some DD4hep knowledge, could you have a look at this, please ?

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (394192a) 49.70% compared to head (0358d4c) 49.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2689   +/-   ##
=======================================
  Coverage   49.70%   49.70%           
=======================================
  Files         474      474           
  Lines       26892    26892           
  Branches    12376    12376           
=======================================
  Hits        13368    13368           
  Misses       4710     4710           
  Partials     8814     8814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asalzburger asalzburger added the Improvement Changes to an existing feature label Nov 17, 2023
Copy link
Contributor

@dimitra97 dimitra97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Only a minor question just for me to understand.
Approving!

@kodiakhq kodiakhq bot merged commit 2097b7a into acts-project:main Nov 17, 2023
53 checks passed
@asalzburger asalzburger deleted the feat-refine-dd4hep-building branch November 17, 2023 12:36
@acts-project-service
Copy link
Collaborator

acts-project-service commented Nov 17, 2023

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 17, 2023
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 17, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants