-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Surfaces: recreate and link unit test PolyhedronSurfaces
#2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolyhedronSurfaces
PolyhedronSurfaces
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2700 +/- ##
=======================================
Coverage 49.51% 49.51%
=======================================
Files 474 474
Lines 27018 27018
Branches 12476 12476
=======================================
Hits 13378 13378
Misses 4764 4764
Partials 8876 8876 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 03a5724physmon summary
|
did you intend to approve this @asalzburger ? |
asalzburger
approved these changes
Nov 30, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
The new CI action checks if most of the files are referenced/included/used at some point. `Scripts`-folders are excluded. Removes files, that are not used (not referenced at any point). For more recent files, I will ping the authors. blocked by - #2700
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
Dec 6, 2023
…t#2678) The new CI action checks if most of the files are referenced/included/used at some point. `Scripts`-folders are excluded. Removes files, that are not used (not referenced at any point). For more recent files, I will ping the authors. blocked by - acts-project#2700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update and finish the unit test for the PolyhedronSurfaces, that was started a few years ago but never linked.
resolves #454