Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Surfaces: recreate and link unit test PolyhedronSurfaces #2700

Merged
merged 11 commits into from
Nov 30, 2023

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Nov 20, 2023

Update and finish the unit test for the PolyhedronSurfaces, that was started a few years ago but never linked.

resolves #454

@AJPfleger AJPfleger marked this pull request as ready for review November 20, 2023 16:11
@AJPfleger AJPfleger changed the title test: Surfaces recreate and link unit test PolyhedronSurfaces test: Surfaces: recreate and link unit test PolyhedronSurfaces Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3cba483) 49.51% compared to head (03a5724) 49.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2700   +/-   ##
=======================================
  Coverage   49.51%   49.51%           
=======================================
  Files         474      474           
  Lines       27018    27018           
  Branches    12476    12476           
=======================================
  Hits        13378    13378           
  Misses       4764     4764           
  Partials     8876     8876           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand andiwand added this to the next milestone Nov 21, 2023
@andiwand
Copy link
Contributor

did you intend to approve this @asalzburger ?

@kodiakhq kodiakhq bot merged commit 9228e3c into acts-project:main Nov 30, 2023
49 checks passed
@acts-project-service
Copy link
Collaborator

@AJPfleger AJPfleger deleted the polyhedron branch November 30, 2023 22:36
kodiakhq bot pushed a commit that referenced this pull request Dec 1, 2023
The new CI action checks if most of the files are referenced/included/used at some point.

`Scripts`-folders are excluded.

Removes files, that are not used (not referenced at any point).

For more recent files, I will ping the authors.

blocked by
- #2700
asalzburger pushed a commit to asalzburger/acts that referenced this pull request Dec 6, 2023
…t#2678)

The new CI action checks if most of the files are referenced/included/used at some point.

`Scripts`-folders are excluded.

Removes files, that are not used (not referenced at any point).

For more recent files, I will ping the authors.

blocked by
- acts-project#2700
@paulgessinger paulgessinger modified the milestones: next, v31.2.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polyhedron surfaces tests are disabled
5 participants