Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: small detector refinements #2703

Merged

Conversation

asalzburger
Copy link
Contributor

This PR does two things:

  • it makes a bit clearer VERBOSE methods
  • It lets you allow to set a minimum number of surfaces needed to even create a layer structure (and not stay with try all(

@asalzburger asalzburger added this to the next milestone Nov 20, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Nov 20, 2023
Core/include/Acts/Detector/LayerStructureBuilder.hpp Outdated Show resolved Hide resolved
Core/src/Detector/LayerStructureBuilder.cpp Outdated Show resolved Hide resolved
Core/src/Detector/LayerStructureBuilder.cpp Outdated Show resolved Hide resolved
Core/src/Detector/LayerStructureBuilder.cpp Show resolved Hide resolved
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (37a2f9e) 49.54% compared to head (8298415) 49.53%.
Report is 1 commits behind head on main.

❗ Current head 8298415 differs from pull request most recent head 5d8edc2. Consider uploading reports for the commit 5d8edc2 to get more accurate results

Files Patch % Lines
Core/src/Detector/LayerStructureBuilder.cpp 16.66% 12 Missing and 13 partials ⚠️
Core/src/Detector/CylindricalContainerBuilder.cpp 0.00% 0 Missing and 2 partials ⚠️
Core/src/Detector/Detector.cpp 50.00% 0 Missing and 1 partial ⚠️
Core/src/Detector/DetectorBuilder.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2703      +/-   ##
==========================================
- Coverage   49.54%   49.53%   -0.02%     
==========================================
  Files         474      474              
  Lines       26929    26936       +7     
  Branches    12425    12432       +7     
==========================================
  Hits        13343    13343              
- Misses       4749     4751       +2     
- Partials     8837     8842       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 4921d08 into acts-project:main Nov 21, 2023
48 checks passed
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants