fix: set fused portals correctly to former keep volume #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for c44b994physmon summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2753 +/- ##
==========================================
- Coverage 49.52% 49.51% -0.02%
==========================================
Files 474 474
Lines 26979 27017 +38
Branches 12454 12476 +22
==========================================
+ Hits 13361 13377 +16
+ Misses 4767 4764 -3
- Partials 8851 8876 +25 ☔ View full report in Codecov by Sentry. |
|
Hey @paulgessinger - I had a spelling error, can you re-approve, please? |
paulgessinger
approved these changes
Nov 30, 2023
acts-project-service
added
the
Fails Athena tests
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
) This PR adds a new `detail/CuboidalDetectorHelper.h/cpp` for creating cuboid shape detectors. Since it reuses some code from the cylindrical infrastructure, this is encapsulated into sub helpers to not be duplicated.  Blocked by: - #2753 (merged) This relaxes the Portal fusing to allow for two portals with same direction filled to be fused (necessary for box-2-box)
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
…ts-project#2754) This PR adds a new `detail/CuboidalDetectorHelper.h/cpp` for creating cuboid shape detectors. Since it reuses some code from the cylindrical infrastructure, this is encapsulated into sub helpers to not be duplicated.  Blocked by: - acts-project#2753 (merged) This relaxes the Portal fusing to allow for two portals with same direction filled to be fused (necessary for box-2-box)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the fused portals correctly back to the former keep volumes that relied on keeping the same shared pointer.
This is an update after #2746 which omitted that.