refactor!: Give CKF BranchStopper access to TrackState #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed if we want the branch stopper to check things like "did we just encounter the second hole in a row". BREAKING CHANGE: The interface of the `BranchStopper` delegate in the CKF extensions goes from ```cpp bool(const CombinatorialKalmanFilterTipState&); ``` to ```cpp bool(const CombinatorialKalmanFilterTipState&, TrackStateProxy&); ```
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2757 +/- ##
==========================================
- Coverage 48.62% 48.62% -0.01%
==========================================
Files 480 480
Lines 28031 28033 +2
Branches 13262 13263 +1
==========================================
Hits 13630 13630
- Misses 4801 4803 +2
Partials 9600 9600 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 1843339physmon summary
|
andiwand
approved these changes
Dec 12, 2023
acts-project-service
added
the
Breaks Athena build
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
…2757) This is needed if we want the branch stopper to check things like "did we just encounter the second hole in a row". BREAKING CHANGE: The interface of the `BranchStopper` delegate in the CKF extensions goes from ```cpp bool(const CombinatorialKalmanFilterTipState&); ``` to ```cpp bool(const CombinatorialKalmanFilterTipState&, TrackStateProxy&); ``` --- This was accidentally merged and then reverted. This is effective the original PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed if we want the branch stopper to check things like "did we just encounter the second hole in a row".
BREAKING CHANGE: The interface of the
BranchStopperdelegate in the CKF extensions goes fromto
This was accidentally merged and then reverted. This is effective the original PR.