chore: Remove volumeSignature from geometry building
#2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2759 +/- ##
=======================================
Coverage 49.50% 49.50%
=======================================
Files 474 474
Lines 27068 27068
Branches 12511 12511
=======================================
Hits 13401 13401
Misses 4761 4761
Partials 8906 8906 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 454e1d8physmon summary
|
acts-project-service
added
the
Breaks Athena build
|
Turns out this breaks Athena. Do we revert until next week? |
paulgessinger
added a commit
to paulgessinger/acts
that referenced
this pull request
Dec 5, 2023
…project#2759)" This reverts commit 34bd984.
Let's revert until next week, although I really like the cleanup - so let's do it regardless later. |
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
Dec 6, 2023
…2759) Seems to have no purpose anymore in ACTS. I was introduced in the pre-PR time: acts-project@cd4c063 Closes acts-project#1731
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
Dec 6, 2023
…#2764) This reverts commit 34bd984 from acts-project#2759 as it breaks Athena compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to have no purpose anymore in ACTS.
I was introduced in the pre-PR time: cd4c063
Closes #1731