chore: bump Python version to 3.12 and update requirements #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Infrastructure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2770 +/- ##
=======================================
Coverage 48.62% 48.62%
=======================================
Files 479 479
Lines 27942 27942
Branches 13213 13213
=======================================
Hits 13588 13588
Misses 4793 4793
Partials 9561 9561 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 98d783ephysmon summary
|
AJPfleger
changed the title
andiwand
approved these changes
Dec 7, 2023
paulgessinger
approved these changes
Dec 12, 2023
acts-project-service
added
the
Fails Athena tests
paulgessinger
removed
the
Fails Athena tests
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
…ect#2770) This PR updates the existing requirements for python-based CI jobs to the newest possible version. It also tries to enforce `python 3.12` (newest) wherever possible. ## Performance boost linux_examples_tests: 18.5 min -> 15 min ## Important changes/notes The `pytest-check 2.2.0..2.2.2` soft-break some CI checks. Therefore, we fix it to `2.1.5.` More to this in issue acts-project#2777 : - linux_test_examples (verified) - test_exatrkx_python (very likely) `uproot 5.x` and `awkward 2.x` change the root-hashes. The test `test_exatrkx_python` got a new separate requirements-file, because the test only runs on `ubuntu 20.04` which uses `python 3.8`. The newest `numpy` (for `awkward` and `uproot`) doesn't support `python 3.8` anymore. When we migrate this test to a newer `OS`, we can use the shared `requirements.txt` again. `clang_tidy` had to be adapted at a few points, since some of`pydantic`'s functionalities were deprecated. ## Side note to `pip-compile` Before generating a new `requirements.txt` one should delete the old one. Otherwise, the versions for the packages are not updated (makes sense to some extent). ## Blocked by other PRs We created files, that were referred to at places we did not check. - acts-project#2778 ## Other Questions The release-workflows still use `3.8`. Should we upgrade as well, or are we too afraid, to break something in there? https://github.com/acts-project/acts/blob/main/.github/workflows/release.yml https://github.com/acts-project/acts/blob/main/.github/workflows/release_pr.yml -> An update to the release script will come in - acts-project#2779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the existing requirements for python-based CI jobs to the newest possible version. It also tries to enforce
python 3.12(newest) wherever possible.Performance boost
linux_examples_tests: 18.5 min -> 15 min
Important changes/notes
The
pytest-check 2.2.0..2.2.2soft-break some CI checks. Therefore, we fix it to2.1.5.More to this in issue #2777 :uproot 5.xandawkward 2.xchange the root-hashes.The test
test_exatrkx_pythongot a new separate requirements-file, because the test only runs onubuntu 20.04which usespython 3.8. The newestnumpy(forawkwardanduproot) doesn't supportpython 3.8anymore. When we migrate this test to a newerOS, we can use the sharedrequirements.txtagain.clang_tidyhad to be adapted at a few points, since some ofpydantic's functionalities were deprecated.Side note to
pip-compileBefore generating a new
requirements.txtone should delete the old one. Otherwise, the versions for the packages are not updated (makes sense to some extent).Blocked by other PRs
We created files, that were referred to at places we did not check.
Other Questions
The release-workflows still use
3.8. Should we upgrade as well, or are we too afraid, to break something in there?https://github.com/acts-project/acts/blob/main/.github/workflows/release.yml
https://github.com/acts-project/acts/blob/main/.github/workflows/release_pr.yml
-> An update to the release script will come in