feat: improve svg display of indexed surfaces #2773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#2751) Adds a template parameter `nDimVertex` to `KalmanVertexUpdater` and `KalmanVertexTrackUpdater`. The new parameter controls whether we perform a usual spatial fit (`nDimVertex = 3`) or if we also fit time (`nDimVertex = 4`). Adds a unit test for Kalman time fitting. Should not break athena! In the long term, we should think about always fitting time.
…t#2678) The new CI action checks if most of the files are referenced/included/used at some point. `Scripts`-folders are excluded. Removes files, that are not used (not referenced at any point). For more recent files, I will ping the authors. blocked by - acts-project#2700
Adds histograms of the track weights from the vertex fit to our physics monitoring. For unweighted vertex fitters, the track weights are 1.
…2759) Seems to have no purpose anymore in ACTS. I was introduced in the pre-PR time: acts-project@cd4c063 Closes acts-project#1731
…#2764) This reverts commit 34bd984 from acts-project#2759 as it breaks Athena compilation.
Update to FTF seeding files. Now creating seeds and efficiency able to be measured This code doesn't include updating the code to modern C++ and renaming classes, these will be in seperate PRs --------- Co-authored-by: Luis Falda Coelho <[email protected]> Co-authored-by: Alexander J. Pfleger <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
github-actions
bot
added
Component - Core
github-actions
bot
removed
Infrastructure
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2773 +/- ##
==========================================
- Coverage 49.48% 49.43% -0.06%
==========================================
Files 474 474
Lines 27075 27119 +44
Branches 12516 12540 +24
==========================================
+ Hits 13399 13406 +7
- Misses 4762 4788 +26
- Partials 8914 8925 +11 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for da9ceacphysmon summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sits on top of #2766 and updates the display a bit.
It allows to visually inspect the bin center and the associated surface centers..