Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use common direction transform Jacobian #2782

Merged
merged 8 commits into from
Dec 22, 2023

Merge branch 'main' into refactor-direction-transform-jacobian

ea6d780
Select commit
Loading
Failed to load commit list.
Merged

refactor: Use common direction transform Jacobian #2782

Merge branch 'main' into refactor-direction-transform-jacobian
ea6d780
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Dec 22, 2023 in 0s

48.83% (-0.05%) compared to c51f48a

View this Pull Request on Codecov

48.83% (-0.05%) compared to c51f48a

Details

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (c51f48a) 48.87% compared to head (ea6d780) 48.83%.

Files Patch % Lines
Core/src/Propagator/detail/CovarianceEngine.cpp 19.04% 5 Missing and 12 partials ⚠️
Core/include/Acts/Utilities/JacobianHelpers.hpp 38.88% 2 Missing and 9 partials ⚠️
Core/src/Surfaces/DiscSurface.cpp 18.18% 4 Missing and 5 partials ⚠️
Core/src/Surfaces/Surface.cpp 0.00% 0 Missing and 4 partials ⚠️
Core/src/Surfaces/LineSurface.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2782      +/-   ##
==========================================
- Coverage   48.87%   48.83%   -0.05%     
==========================================
  Files         485      486       +1     
  Lines       28205    28175      -30     
  Branches    13286    13285       -1     
==========================================
- Hits        13786    13760      -26     
+ Misses       4829     4820       -9     
- Partials     9590     9595       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov