-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Split propagator options #3181
Merged
kodiakhq
merged 11 commits into
acts-project:main
from
andiwand:refactor-split-propagator-options
Jul 12, 2024
Merged
refactor!: Split propagator options #3181
kodiakhq
merged 11 commits into
acts-project:main
from
andiwand:refactor-split-propagator-options
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Fatras
Affects the Fatras module
Component - Examples
Affects the Examples module
Vertexing
Track Finding
Track Fitting
Component - Documentation
Affects the documentation
labels
May 9, 2024
📊: Physics performance monitoring for 767ea73physmon summary
|
andiwand
force-pushed
the
refactor-split-propagator-options
branch
from
May 10, 2024 12:02
257a9f2
to
8a8570c
Compare
andiwand
force-pushed
the
refactor-split-propagator-options
branch
from
May 15, 2024 09:41
8a8570c
to
d329f61
Compare
andiwand
force-pushed
the
refactor-split-propagator-options
branch
2 times, most recently
from
June 8, 2024 15:24
ebbb3e1
to
c06b7a3
Compare
andiwand
force-pushed
the
refactor-split-propagator-options
branch
from
June 8, 2024 17:33
f65d5b6
to
6125a2f
Compare
andiwand
force-pushed
the
refactor-split-propagator-options
branch
4 times, most recently
from
July 9, 2024 13:03
758e622
to
914c42d
Compare
andiwand
force-pushed
the
refactor-split-propagator-options
branch
from
July 11, 2024 05:37
5f0909e
to
f6db134
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall!
Co-authored-by: Paul Gessinger <[email protected]>
paulgessinger
approved these changes
Jul 12, 2024
in case there are more sonarcloud issues I will follow that up in one of the sacked PRs |
Quality Gate passedIssues Measures |
✅ Athena integration test results [7db63a6]✅ All tests successful
|
acts-project-service
added
the
Breaks Athena build
This PR breaks the Athena build
label
Jul 12, 2024
This was referenced Jul 13, 2024
paulgessinger
pushed a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Core
Affects the Core module
Component - Documentation
Affects the documentation
Component - Examples
Affects the Examples module
Component - Fatras
Affects the Fatras module
Track Finding
Track Fitting
Vertexing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our propagator options cannot communicate stepper or navigator specific options which would come handy for example for the
DirectNavigator
to communicate the surface sequence before starting the propagation.Summary of the changes in this PR
StepperPlainOptions
andNavigatorPlainOptions
PropagatorPlainOptions
dependent onStepperPlainOptions
andNavigatorPlainOptions