fix: limit cylinderSurface pathCorrection

[AJPfleger]

To follow-up on the path correction bug, which I tried to fix in

• fix: add safeDivide to cylinderSurface pathCorrection #3254

(first fix was not so well received, since it was not clear enough what values to expect)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.65%. Comparing base (80a03ea) to head (8dd41b7).
Report is 284 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3255   +/-   ##
=======================================
  Coverage   47.65%   47.65%           
=======================================
  Files         507      507           
  Lines       29205    29205           
  Branches    14010    14010           
=======================================
  Hits        13917    13917           
  Misses       5264     5264           
  Partials    10024    10024           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 8dd41b7

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[andiwand]

@AJPfleger do you know in what situation this pops up? I am a bit worried that we are treating a symptom here and by doing that we will hide a deeper cause. I believe this case is not impossible but should be extremely rare. So if we are not super unlucky or run 10^9 particles with sufficiently low momentum or high energy loss I have a hard time imagining that this happens just by chance.

Apart from that the path correction is implemented similarly for other surfaces. I wonder if we want to solve this problem for all of them.

[AJPfleger]

@andiwand I had it pop up in 3 of 10k events in this physmon test:

• https://github.com/acts-project/acts/runs/25848664141

[AJPfleger]

Closed in favour of a possible better solution and tracked here:

• bug: navigation suggests pathCorrection=inf on cylinderSurface #3267