feat: traccc plugin (conversion)

.github/workflows/builds.yml

@@ -389,6 +389,7 @@ jobs:
           -DACTS_FORCE_ASSERTIONS=ON
           -DACTS_BUILD_EXAMPLES_EDM4HEP=ON
           -DACTS_BUILD_PLUGIN_ACTSVG=ON
+          -DACTS_USE_SYSTEM_NLOHMANN_JSON=ON
       - name: Build
         run: cmake --build build
       - name: ccache stats

.gitlab-ci.yml

@@ -48,6 +48,7 @@ clang_tidy:
         clang-tidy/clang-tidy.json
         --exclude "*thirdparty*"
         --exclude "*ActsPodioEdm*"
+        --exclude "*build/_deps/*"
 
     # Check the combined report against the defined limits
     - CI/clang_tidy/check_clang_tidy.py --report clang-tidy/clang-tidy.json --config CI/clang_tidy/limits.yml

CMakeLists.txt

@@ -37,8 +37,6 @@ option(ACTS_BUILD_PLUGIN_PODIO "Build Podio plugin" OFF)
 option(ACTS_BUILD_PLUGIN_EDM4HEP "Build EDM4hep plugin" OFF)
 option(ACTS_BUILD_PLUGIN_FPEMON "Build FPE monitoring plugin" OFF)
 option(ACTS_BUILD_PLUGIN_GEOMODEL "Build GeoModel plugin" OFF)
-option(ACTS_BUILD_PLUGIN_COVFIE "Build Covfie plugin" OFF)
-option(ACTS_BUILD_PLUGIN_DETRAY "Build Detray plugin" OFF)
 option(ACTS_BUILD_PLUGIN_TRACCC "Build Traccc plugin" OFF)
 option(ACTS_USE_SYSTEM_GEOMODEL "Use a system-provided GeoModel installation" ${ACTS_USE_SYSTEM_LIBS})
 option(ACTS_BUILD_PLUGIN_GEANT4 "Build Geant4 plugin" OFF)
@@ -50,25 +48,25 @@ option(ACTS_BUILD_PLUGIN_JSON "Build json plugin" OFF)
 option(ACTS_USE_SYSTEM_NLOHMANN_JSON "Use nlohmann::json provided by the system instead of the bundled version" ${ACTS_USE_SYSTEM_LIBS})
 option(ACTS_BUILD_PLUGIN_LEGACY "Build legacy plugin" OFF)
 option(ACTS_BUILD_PLUGIN_ONNX "Build ONNX plugin" OFF)
-option(ACTS_SETUP_COVFIE "Explicitly set up covfie for the project" OFF)
+option(ACTS_SETUP_COVFIE "Explicitly set up covfie for the project" ON)
 option(ACTS_USE_SYSTEM_COVFIE "Use a system-provided covfie installation" ${ACTS_USE_SYSTEM_LIBS})
-option(ACTS_SETUP_DETRAY "Explicitly set up detray for the project" OFF)
+option(ACTS_SETUP_DETRAY "Explicitly set up detray for the project" ON)
 option(ACTS_USE_SYSTEM_DETRAY "Use a system-provided detray installation" ${ACTS_USE_SYSTEM_LIBS})
-option(ACTS_SETUP_TRACCC "Explicitly set up traccc for the project" OFF)
+option(ACTS_SETUP_TRACCC "Explicitly set up traccc for the project" ON)
 option(ACTS_USE_SYSTEM_TRACCC "Use a system-provided traccc installation" ${ACTS_USE_SYSTEM_LIBS})
 option(ACTS_SETUP_DFELIBS "Explicitly set up dfelibs for the project" ON)
 option(ACTS_USE_SYSTEM_DFELIBS "Use a system-provided dfelibs installation" ${ACTS_USE_SYSTEM_LIBS})
-option(ACTS_SETUP_VECMEM "Explicitly set up vecmem for the project" OFF)
+option(ACTS_SETUP_VECMEM "Explicitly set up vecmem for the project" ON)
 option(ACTS_USE_SYSTEM_VECMEM "Use a system-provided vecmem installation" ${ACTS_USE_SYSTEM_LIBS})
-option(ACTS_SETUP_ALGEBRAPLUGINS "Explicitly set up algebra-plugins for the project" OFF)
+option(ACTS_SETUP_ALGEBRAPLUGINS "Explicitly set up algebra-plugins for the project" ON)
 option(ACTS_USE_SYSTEM_ALGEBRAPLUGINS "Use a system-provided algebra-plugins installation" ${ACTS_USE_SYSTEM_LIBS})
 option(ACTS_BUILD_PLUGIN_TGEO "Build TGeo plugin" OFF)
 # fatras related options
 option(ACTS_BUILD_FATRAS "Build FAst TRAcking Simulation package" OFF)
 option(ACTS_BUILD_FATRAS_GEANT4 "Build Geant4 Fatras package" OFF)
 # alignment related options
 option(ACTS_BUILD_ALIGNMENT "Build Alignment package" OFF)
-# examples related options
+# examples related optionsExplicitly set up vecmem for the project<br> type
 option(ACTS_BUILD_EXAMPLES "Build standalone examples" OFF)
 option(ACTS_BUILD_EXAMPLES_DD4HEP "Build DD4hep-based code in the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_EDM4HEP "Build EDM4hep-based code in the examples" OFF)
@@ -154,16 +152,20 @@ set_option_if(
 set_option_if(
   ACTS_BUILD_PLUGIN_TGEO
   ACTS_BUILD_PLUGIN_DD4HEP OR ACTS_BUILD_EXAMPLES OR ACTS_BUILD_EVERYTHING)
+set_option_if(ACTS_BUILD_PLUGIN_TRACCC
+  ACTS_BUILD_EVERYTHING)
 set_option_if(
   ACTS_BUILD_PLUGIN_JSON
-  ACTS_BUILD_EXAMPLES OR ACTS_BUILD_EVERYTHING)
+  ACTS_BUILD_EXAMPLES OR ACTS_BUILD_EVERYTHING OR ACTS_BUILD_PLUGIN_TRACCC)
 set_option_if(
   ACTS_BUILD_FATRAS
   ACTS_BUILD_EXAMPLES OR ACTS_BUILD_EVERYTHING)
 set_option_if(ACTS_BUILD_PLUGIN_LEGACY ACTS_BUILD_EVERYTHING)
 set_option_if(ACTS_BUILD_PLUGIN_EXATRKX ACTS_BUILD_EXAMPLES_EXATRKX)
 set_option_if(ACTS_BUILD_PLUGIN_FPEMON
   ACTS_BUILD_EXAMPLES OR ACTS_BUILD_EVERYTHING)
+set_option_if(ACTS_BUILD_PLUGIN_TRACCC
+  ACTS_BUILD_EXAMPLES OR ACTS_BUILD_EVERYTHING)
 
 # feature tests
 include(CheckCXXSourceCompiles)
@@ -266,24 +268,6 @@ if (ACTS_SETUP_DFELIBS)
   endif()
 endif()
 
-if (ACTS_SETUP_VECMEM)
-  if (ACTS_USE_SYSTEM_VECMEM)
-    find_package(vecmem ${_acts_vecmem_version} REQUIRED)
-  else()
-    add_subdirectory(thirdparty/vecmem)
-    # Make the "VecMem language code" available for the whole project.
-    include( "${VECMEM_LANGUAGE_DIR}/vecmem-check-language.cmake" )
-  endif()
-endif()
-
-if (ACTS_SETUP_ALGEBRAPLUGINS)
-  if (ACTS_USE_SYSTEM_ALGEBRAPLUGINS)
-    find_package(algebra-plugins ${_acts_algebraplugins_version} REQUIRED)
-  else()
-    add_subdirectory(thirdparty/algebra-plugins)
-  endif()
-endif()
-
 find_package(Filesystem REQUIRED)
 
 # the `<project_name>_VERSION` variables set by `setup(... VERSION ...)` have
@@ -318,27 +302,6 @@ endmacro()
 # when a particular package is actually needed.
 
 # plugin dependencies
-if(ACTS_SETUP_COVFIE)
-  if(ACTS_USE_SYSTEM_COVFIE)
-    find_package(covfie ${_acts_covfie_version} REQUIRED CONFIG)
-  else()
-    add_subdirectory(thirdparty/covfie)
-  endif()
-endif()
-if(ACTS_SETUP_DETRAY)
-  if(ACTS_USE_SYSTEM_DETRAY)
-    find_package(detray ${_acts_detray_version} REQUIRED CONFIG)
-  else()
-    add_subdirectory(thirdparty/detray)
-  endif()
-endif()
-if(ACTS_SETUP_TRACCC)
-  if(ACTS_USE_SYSTEM_TRACCC)
-    find_package(traccc ${_acts_traccc_version} REQUIRED CONFIG)
-  else()
-    add_subdirectory(thirdparty/traccc)
-  endif()
-endif()
 
 if(ACTS_BUILD_PLUGIN_ACTSVG)
   if(ACTS_USE_SYSTEM_ACTSVG)
@@ -419,6 +382,52 @@ if(ACTS_BUILD_PLUGIN_GEANT4)
   find_package(Geant4 REQUIRED CONFIG COMPONENTS gdml)
 endif()
 
+if (ACTS_BUILD_PLUGIN_TRACCC)
+  if (ACTS_SETUP_VECMEM)
+    if (ACTS_USE_SYSTEM_VECMEM)
+      find_package(vecmem ${_acts_vecmem_version} REQUIRED)
+    else()
+      add_subdirectory(thirdparty/vecmem)
+    endif()
+  endif()
+
+  if (ACTS_SETUP_ALGEBRAPLUGINS)
+
+    add_definitions(-DALGEBRA_PLUGINS_INCLUDE_ARRAY)
+
+    if (ACTS_USE_SYSTEM_ALGEBRAPLUGINS)
+      find_package(algebra-plugins ${_acts_algebraplugins_version} REQUIRED)
+    else()
+      add_subdirectory(thirdparty/algebra-plugins)
+    endif()
+  endif()
+
+  if(ACTS_SETUP_COVFIE)
+    if(ACTS_USE_SYSTEM_COVFIE)
+      find_package(covfie ${_acts_covfie_version} REQUIRED CONFIG)
+    else()
+      add_subdirectory(thirdparty/covfie)
+    endif()
+  endif()
+
+  if(ACTS_SETUP_DETRAY)
+    if(ACTS_USE_SYSTEM_DETRAY)
+      find_package(detray ${_acts_detray_version} REQUIRED CONFIG)
+    else()
+      add_subdirectory(thirdparty/detray)
+    endif()
+  endif()
+
+  if(ACTS_SETUP_TRACCC)
+    if(ACTS_USE_SYSTEM_TRACCC)
+      find_package(traccc ${_acts_traccc_version} REQUIRED CONFIG)
+    else()
+      add_subdirectory(thirdparty/traccc)
+    endif()
+  endif()
+
+endif()
+
 # examples dependencies
 if(ACTS_BUILD_EXAMPLES)
   set(THREADS_PREFER_PTHREAD_FLAG ON)

Core/include/Acts/EventData/MultiTrajectory.hpp

@@ -88,6 +88,12 @@ class TrackStateRange {
       }
     }
 
+    Iterator operator++(int) {
+      Iterator tmp(*this);
+      operator++();
+      return tmp;
+    }
+
     bool operator==(const Iterator& other) const {
       if (!proxy && !other.proxy) {
         return true;
@@ -107,8 +113,8 @@ class TrackStateRange {
   TrackStateRange(ProxyType _begin) : m_begin{_begin} {}
   TrackStateRange() : m_begin{std::nullopt} {}
 
-  Iterator begin() { return m_begin; }
-  Iterator end() { return Iterator{std::nullopt}; }
+  Iterator begin() const { return m_begin; }
+  Iterator end() const { return Iterator{std::nullopt}; }
 
  private:
   Iterator m_begin;

Core/include/Acts/Utilities/BinningData.hpp

@@ -243,10 +243,10 @@ class BinningData {
     // ordered after occurrence
     if (binvalue == BinningValue::binR || binvalue == BinningValue::binRPhi ||
         binvalue == BinningValue::binX || binvalue == BinningValue::binH) {
-      return lposition[0];
+      return static_cast<float>(lposition[0]);
     }
 
-    return lposition[1];
+    return static_cast<float>(lposition[1]);
   }
 
   /// Take the right float value
@@ -260,19 +260,19 @@ class BinningData {
     using VectorHelpers::phi;
     // ordered after occurrence
     if (binvalue == BinningValue::binR || binvalue == BinningValue::binH) {
-      return (perp(position));
+      return static_cast<float>(perp(position));
     }
     if (binvalue == BinningValue::binRPhi) {
-      return (perp(position) * phi(position));
+      return static_cast<float>(perp(position) * phi(position));
     }
     if (binvalue == BinningValue::binEta) {
-      return (eta(position));
+      return static_cast<float>(eta(position));
     }
     if (toUnderlying(binvalue) < 3) {
       return static_cast<float>(position[toUnderlying(binvalue)]);
     }
     // phi gauging
-    return phi(position);
+    return static_cast<float>(phi(position));
   }
 
   /// Get the center value of a bin
@@ -284,7 +284,7 @@ class BinningData {
     const std::vector<float>& bvals = boundaries();
     // take the center between bin boundaries
     float value =
-        bin < (bvals.size() - 1) ? 0.5 * (bvals[bin] + bvals[bin + 1]) : 0.;
+        bin < (bvals.size() - 1) ? 0.5f * (bvals[bin] + bvals[bin + 1]) : 0.f;
     return value;
   }
 
@@ -296,7 +296,7 @@ class BinningData {
   float width(std::size_t bin) const {
     const std::vector<float>& bvals = boundaries();
     // take the center between bin boundaries
-    float value = bin < (bvals.size() - 1) ? bvals[bin + 1] - bvals[bin] : 0.;
+    float value = bin < (bvals.size() - 1) ? bvals[bin + 1] - bvals[bin] : 0.f;
     return value;
   }
 
@@ -419,11 +419,11 @@ class BinningData {
   /// @return the center value of the bin is given
   float centerValue(std::size_t bin) const {
     if (zdim) {
-      return 0.5 * (min + max);
+      return 0.5f * (min + max);
     }
     float bmin = m_boundaries[bin];
     float bmax = bin < m_boundaries.size() ? m_boundaries[bin + 1] : max;
-    return 0.5 * (bmin + bmax);
+    return 0.5f * (bmin + bmax);
   }
 
  private:

Examples/Python/CMakeLists.txt

@@ -85,13 +85,6 @@ else()
   target_sources(ActsPythonBindings PRIVATE src/GeoModelStub.cpp)
 endif()
 
-if(ACTS_BUILD_PLUGIN_DETRAY)
-  target_link_libraries(ActsPythonBindings PUBLIC ActsPluginDetray)
-  target_sources(ActsPythonBindings PRIVATE src/Detray.cpp)
-else()
-  target_sources(ActsPythonBindings PRIVATE src/DetrayStub.cpp)
-endif()
-
 if(ACTS_BUILD_PLUGIN_ACTSVG)
   target_link_libraries(ActsPythonBindings PUBLIC ActsExamplesIoSvg)
   target_sources(ActsPythonBindings PRIVATE src/Svg.cpp)
@@ -205,6 +198,16 @@ else()
   target_sources(ActsPythonBindings PRIVATE src/OnnxNeuralCalibratorStub.cpp)
 endif()
 
+if(ACTS_BUILD_PLUGIN_TRACCC)
+  target_link_libraries(ActsPythonBindings PUBLIC ActsPluginCovfie)
+  target_sources(ActsPythonBindings PRIVATE src/Covfie.cpp)
+  target_link_libraries(ActsPythonBindings PUBLIC ActsPluginDetray)
+  target_sources(ActsPythonBindings PRIVATE src/Detray.cpp)
+else()
+  target_sources(ActsPythonBindings PRIVATE src/CovfieStub.cpp)
+  target_sources(ActsPythonBindings PRIVATE src/DetrayStub.cpp)
+endif()
+
 configure_file(setup.sh.in ${_python_dir}/setup.sh @ONLY)
 install(FILES ${_python_dir}/setup.sh DESTINATION "python")
 

Examples/Python/python/acts/examples/reconstruction.py

@@ -1870,7 +1870,7 @@ def addAmbiguityResolutionMLDBScan(
     addTrackWriters(
         s,
         name="ambiMLDBScan",
-        trajectories=alg.config.outputTracks,
+        tracks=alg.config.outputTracks,
         outputDirRoot=outputDirRoot,
         outputDirCsv=outputDirCsv,
         writeStates=writeTrajectories,

Examples/Python/src/Covfie.cpp

@@ -0,0 +1,62 @@
+// This file is part of the Acts project.
+//
+// Copyright (C) 2021 CERN for the benefit of the Acts project
+//
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+#include "Acts/Plugins/Covfie/FieldConversion.hpp"
+#include "Acts/Plugins/Python/Utilities.hpp"
+
+#include <pybind11/pybind11.h>
+#include <pybind11/stl.h>
+
+namespace py = pybind11;
+using namespace pybind11::literals;
+
+namespace Acts::Python {
+
+namespace {
+
+template <typename field_t>
+typename field_t::view_t newView(const field_t& field) {
+  typename field_t::view_t view(field);
+  return view;
+}
+
+template <typename field_t>
+void declareCovfieField(py::module& m, const std::string& fieldName) {
+  using view_t = typename field_t::view_t;
+  m.def("newView", static_cast<view_t (*)(const field_t&)>(&newView));
+  py::class_<field_t, std::shared_ptr<field_t>>(m, fieldName.c_str());
+  py::class_<view_t, std::shared_ptr<view_t>>(
+      m, (fieldName + std::string("View")).c_str())
+      .def("at", &view_t::template at<float, float, float>);
+}
+
+}  // namespace
+void addCovfie(Context& ctx) {
+  auto main = ctx.get("main");
+  auto m = main.def_submodule("covfie", "Submodule for covfie conversion");
+
+  declareCovfieField<Acts::CovfiePlugin::ConstantField>(m,
+                                                        "CovfieConstantField");
+  declareCovfieField<Acts::CovfiePlugin::InterpolatedField>(
+      m, "CovfieAffineLinearStridedField");
+
+  m.def("covfieField",
+        py::overload_cast<const Acts::InterpolatedMagneticField&>(
+            &Acts::CovfiePlugin::covfieField));
+  m.def("covfieField", py::overload_cast<const Acts::ConstantBField&>(
+                           &Acts::CovfiePlugin::covfieField));
+  m.def(
+      "covfieField",
+      py::overload_cast<const Acts::MagneticFieldProvider&,
+                        Acts::MagneticFieldProvider::Cache&,
+                        const std::vector<std::size_t>&,
+                        const std::vector<double>&, const std::vector<double>&>(
+          &Acts::CovfiePlugin::covfieField));
+}
+
+}  // namespace Acts::Python