Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gx2f): material effects - multiple scattering #3292

Merged
merged 88 commits into from
Aug 30, 2024

Conversation

@AJPfleger AJPfleger added this to the next milestone Jun 14, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Jun 14, 2024
@AJPfleger AJPfleger added the 🛑 blocked This item is blocked by another item label Jun 14, 2024
Copy link

github-actions bot commented Jun 15, 2024

📊: Physics performance monitoring for dfd18c7

Full contents

physmon summary

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 104 lines in your changes missing coverage. Please review.

Project coverage is 47.30%. Comparing base (cf9d872) to head (f0b690c).
Report is 6 commits behind head on main.

Current head f0b690c differs from pull request most recent head 6371958

Please upload reports for the commit 6371958 to get more accurate results.

Files Patch % Lines
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 27.27% 41 Missing and 63 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3292      +/-   ##
==========================================
+ Coverage   47.24%   47.30%   +0.06%     
==========================================
  Files         508      512       +4     
  Lines       30041    30539     +498     
  Branches    14586    14852     +266     
==========================================
+ Hits        14192    14446     +254     
- Misses       5375     5434      +59     
- Partials    10474    10659     +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Jun 15, 2024
@andiwand andiwand removed the 🛑 blocked This item is blocked by another item label Aug 30, 2024
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I took a quick look at the code without a deep dive on the math since you are the expert there anyways. Happy to merge after reverting the CI workflow

.github/workflows/builds.yml Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
Core/include/Acts/TrackFitting/GlobalChiSquareFitter.hpp Outdated Show resolved Hide resolved
@AJPfleger AJPfleger requested a review from andiwand August 30, 2024 13:36
@andiwand andiwand marked this pull request as ready for review August 30, 2024 14:02
Copy link

@kodiakhq kodiakhq bot merged commit 2493b0e into acts-project:main Aug 30, 2024
42 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 30, 2024
@AJPfleger AJPfleger deleted the gx2f-material branch August 31, 2024 17:24
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests Infrastructure Changes to build tools, continous integration, ... Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants