-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gx2f): material effects - multiple scattering #3292
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3292 +/- ##
==========================================
+ Coverage 47.24% 47.30% +0.06%
==========================================
Files 508 512 +4
Lines 30041 30539 +498
Branches 14586 14852 +266
==========================================
+ Hits 14192 14446 +254
- Misses 5375 5434 +59
- Partials 10474 10659 +185 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 I took a quick look at the code without a deep dive on the math since you are the expert there anyways. Happy to merge after reverting the CI workflow
Quality Gate passedIssues Measures |
blocked by:
addToGx2fSums
#3568