Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix a number of SonarQube reliability issues #3328

Merged
merged 19 commits into from
Jul 1, 2024

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Jun 24, 2024

This PR

  • Modifies the logging macros so that they require a ; now
  • Modifies the DD4hep conversion to not leak memory, but instead attach the ACTS detector element lifetime to the DD4hep detector element
  • Adds an explicit cast from uint64_t to uint32_t
  • Makes a number of constructors explicit and/or noexcept
  • Avoids some problematic integer manipulations
  • Avoids throwing std::string as an exception
  • + a few smaller fixes

@paulgessinger paulgessinger added this to the v36.0.0 milestone Jun 24, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Event Data Model labels Jun 24, 2024
@AJPfleger AJPfleger requested review from AJPfleger June 25, 2024 16:20
Copy link

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kodiakhq kodiakhq bot merged commit 501bdf8 into acts-project:main Jul 1, 2024
57 checks passed
@github-actions github-actions bot removed the automerge label Jul 1, 2024
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants