Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Truth graph metrics for Exa.TrkX with separate algorithm #3354

Merged
merged 12 commits into from
Jul 11, 2024
Merged

refactor: Truth graph metrics for Exa.TrkX with separate algorithm #3354

merged 12 commits into from
Jul 11, 2024

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Jul 8, 2024 •
edited
Loading

Refactors code for truth graph building into separate algorithm, also improve reader/writer infrastructure for graphs.

@benjaminhuth benjaminhuth added this to the next milestone Jul 8, 2024
@github-actions github-actions bot added Component - Examples Affects the Examples module Track Finding labels Jul 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

📊: Physics performance monitoring for 5512d97

Full contents

physmon summary

andiwand
andiwand previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 left a few comments

Examples/Algorithms/TrackFindingExaTrkX/src/TruthGraphBuilder.cpp Outdated Show resolved Hide resolved
Examples/Algorithms/TrackFindingExaTrkX/src/TruthGraphBuilder.cpp Outdated Show resolved Hide resolved
Examples/Algorithms/TrackFindingExaTrkX/src/TruthGraphBuilder.cpp Outdated Show resolved Hide resolved
Examples/Framework/include/ActsExamples/EventData/Graph.hpp Outdated Show resolved Hide resolved
andiwand
andiwand previously approved these changes Jul 11, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 2413095 into acts-project:main Jul 11, 2024
52 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 11, 2024 •
edited
Loading

🔴 Athena integration test results [2413095]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 11, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module Event Data Model Track Finding
Projects
None yet
Milestone
v36.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@benjaminhuth @acts-project-service @andiwand @paulgessinger