Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve Athena Dump reader #3358

Merged
merged 5 commits into from
Jul 12, 2024
Merged

feat: Improve Athena Dump reader #3358

merged 5 commits into from
Jul 12, 2024

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Jul 9, 2024 •
edited
Loading

Can read more things now.

@benjaminhuth benjaminhuth added this to the next milestone Jul 9, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Jul 9, 2024
@benjaminhuth benjaminhuth added the 🛑 blocked This item is blocked by another item label Jul 9, 2024
@benjaminhuth benjaminhuth marked this pull request as draft July 9, 2024 12:27
andiwand
andiwand previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 left a few minor comments

Examples/Io/Root/src/RootAthenaDumpReader.cpp Outdated Show resolved Hide resolved
Examples/Io/Root/src/RootAthenaDumpReader.cpp Outdated Show resolved Hide resolved
Examples/Io/Root/src/RootAthenaDumpReader.cpp Outdated Show resolved Hide resolved
@benjaminhuth benjaminhuth marked this pull request as ready for review July 11, 2024 16:46
@benjaminhuth benjaminhuth requested a review from andiwand July 11, 2024 16:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

📊: Physics performance monitoring for 1772683

Full contents

physmon summary

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@paulgessinger
Copy link
Member

Is this ready or still blocked?

@benjaminhuth benjaminhuth removed the 🛑 blocked This item is blocked by another item label Jul 12, 2024
@benjaminhuth benjaminhuth merged commit 6334171 into acts-project:main Jul 12, 2024
51 checks passed
@benjaminhuth benjaminhuth deleted the feature/improve-athena-dump-reader branch July 12, 2024 06:59
@benjaminhuth
Copy link
Member Author

Sorry forgot the label

@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 12, 2024 •
edited
Loading

✅ Athena integration test results [6334171]

✅ All tests successful

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_unit_tests

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 12, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module
Projects
None yet
Milestone
v36.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@benjaminhuth @paulgessinger @acts-project-service @andiwand