Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip outliers in GreedyAmbiguityResolution #3452

Merged
merged 3 commits into from
Aug 5, 2024
Merged

fix: Skip outliers in GreedyAmbiguityResolution #3452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0c7636
fix: Skip outliers in `GreedyAmbiguityResolution`
andiwand Jul 29, 2024
ea439cd
Merge branch 'main' into fix-greedyambisolver-skip-outliers
andiwand Aug 5, 2024
250ae6a
update ref
andiwand Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified CI/physmon/reference/performance_ambi_ttbar.root
View file
Open in desktop
Binary file not shown.
Binary file modified CI/physmon/reference/performance_amvf_gridseeder_ttbar_hist.root
View file
Open in desktop
Binary file not shown.
Binary file modified CI/physmon/reference/performance_amvf_ttbar_hist.root
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion Core/include/Acts/AmbiguityResolution/GreedyAmbiguityResolution.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// This file is part of the Acts project.
//
// Copyright (C) 2020 CERN for the benefit of the Acts project
// Copyright (C) 2023-2024 CERN for the benefit of the Acts project
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
Expand Down
7 changes: 5 additions & 2 deletions Core/include/Acts/AmbiguityResolution/GreedyAmbiguityResolution.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// This file is part of the Acts project.
//
// Copyright (C) 2020 CERN for the benefit of the Acts project
// Copyright (C) 2023-2024 CERN for the benefit of the Acts project
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
Expand All @@ -9,6 +9,7 @@
#pragma once

#include "Acts/AmbiguityResolution/GreedyAmbiguityResolution.hpp"
#include "Acts/EventData/TrackStateType.hpp"

#include <unordered_map>

Expand Down Expand Up @@ -36,7 +37,9 @@ void GreedyAmbiguityResolution::computeInitialState(
}
std::vector<std::size_t> measurements;
for (auto ts : track.trackStatesReversed()) {
if (ts.typeFlags().test(Acts::TrackStateFlag::MeasurementFlag)) {
bool isMeasurement = ts.typeFlags().test(TrackStateFlag::MeasurementFlag);
bool isOutlier = ts.typeFlags().test(TrackStateFlag::OutlierFlag);
if (isMeasurement && !isOutlier) {
SourceLink sourceLink = ts.getUncalibratedSourceLink();
// assign a new measurement index if the source link was not seen yet
auto emplace = measurementIndexMap.try_emplace(
Expand Down
2 changes: 1 addition & 1 deletion Core/src/AmbiguityResolution/GreedyAmbiguityResolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// This file is part of the Acts project.
//
// Copyright (C) 2023 CERN for the benefit of the Acts project
// Copyright (C) 2023-2024 CERN for the benefit of the Acts project
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
Expand Down
Loading