ci: Disable clang-tidy for external dependencies #3477
Conversation
When using CMake's FetchContent mechanism, the source code for those dependencies ends up in the `build/_deps/` directory, which was previously subject to analysis by clang-tidy, which can lead to errors rooted in external projects. This commit disables clang-tidy for that directory, resolving the issue. Co-authored-by: Stephen Nicholas Swatman <[email protected]>
📊: Physics performance monitoring for e8b5cbaphysmon summary
|
Do you mean adding the |
|
|
I think the system flag is too new for what we require as a minimum version. But I think it would already be enough to build the dependencies externally instead of basically doing |
|
Yeah, FetchContent is a crime against programming; but don't we use it for other dependencies already? |
|
FWIW: I'd be extremely excited to get rid of the FetchContent because, as you say, the way it intertwines the build systems of projects is basically unmanageable for any non-trivial software. |
|
Yeah sorry to open up that can here. No need to change anything on this PR. Just one more example why |
acts-project-service
added
the
Breaks Athena build
|
I like I'd argue the problem isn't |
|
What I think is problematic about it is that we share variables transparently with another project. Calling external build with the flags we actually want to transmit would be much better in my opinion. How we want to download stuff is a different story. To me it just seems like we are using a build system as a package manager which it is not really built for |
When using CMake's FetchContent mechanism, the source code for those dependencies ends up in the
build/_deps/directory, which was previously subject to analysis by clang-tidy, which can lead to errors rooted in external projects. This commit disables clang-tidy for that directory, resolving the issue.This commit comes from #3117.