build: Improve traccc dependency loading #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Infrastructure
📊: Physics performance monitoring for ba4e420physmon summary
|
|
Actually, this needs more integration with the |
stephenswat
force-pushed
the
build/update_traccc_externals
branch
from
0cc148a to
bffa47c
Compare
|
Okay, this should now be good to go. |
stephenswat
force-pushed
the
build/update_traccc_externals
branch
2 times, most recently
from
d991cd1 to
f291f92
Compare
This commit makes a few changes to the way some of the Acts R&D projects are loaded in Acts (i.e. detray, traccc, algebra-plugins), namely: 1. It adds code to load detray's dependencies if the Acts project is installed. 2. It updates the versions of detray and traccc so they are compatible. 3. It adds some documentation to the `thirdparty/` directory. 4. It refines the parameters for the CMake build systems of various projects to be more robust. 5. It establishes a dependency of the traccc plugin on the detray plugin, and the detray plugin on the covfie plugin. Co-authored-by: Stephen Nicholas Swatman <[email protected]>
|
|
@andiwand any idea why policy-bot is refusing to accept this? |
andiwand
approved these changes
Aug 6, 2024
|
looks like I didn't approve 😅 |
acts-project-service
added
the
Breaks Athena build
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
This commit adds a new Acts plugin that adds support for magnetic fields implemented using the covfie library. This commit is based on #3117. Closes #3117. Depends on #3478. Virtually all credit goes to @fredevb. Co-authored-by: Fred <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes a few changes to the way some of the Acts R&D projects are loaded in Acts (i.e. detray, traccc, algebra-plugins), namely:
thirdparty/directory.This commit comes from #3117.