Code

feat(geo): Gen3 portal links#3531

Code

Merged

kodiakhq[bot] merged 101 commits intoacts-project:mainacts-project/acts:mainfrom paulgessinger:feat/gen3-portal-linkspaulgessinger/acts:feat/gen3-portal-linksCopy head branch name to clipboardAug 26, 2024

+4,647-11

Commits

Commits on Aug 21, 2024

• feat(geo): TrackingGeometry setVolumeName method

  paulgessinger

  committed
  1de1182

  Copy full SHA for 1de1182

• feat(geo): TrackingVolume move constructor

  paulgessinger

  committed
  44e5903

  Copy full SHA for 44e5903

Commits on Aug 22, 2024

• feat(geo): Surface::isOnSurface gets tolerance parameter

  paulgessinger

  committed
  c371fb7

  Copy full SHA for c371fb7

• Portal stitching exploration

  paulgessinger

  committed
  3db513d

  Copy full SHA for 3db513d

• checkpoint w/o double-dispatch

  paulgessinger

  committed
  ba11b51

  Copy full SHA for ba11b51

• portal: more portal merging exploration

  paulgessinger

  committed
  13f1041

  Copy full SHA for 13f1041

• fixes after axis refactor

  paulgessinger

  committed
  3d39501

  Copy full SHA for 3d39501

• wip

  paulgessinger

  committed
  f81860b

  Copy full SHA for f81860b

• fix axistype tags

  paulgessinger

  committed
  b7e1899

  Copy full SHA for b7e1899

• portal testing

  paulgessinger

  committed
  7c5cf1f

  Copy full SHA for 7c5cf1f

• fix format

  paulgessinger

  committed
  0db5fff

  Copy full SHA for 0db5fff

• wip

  paulgessinger

  committed
  9d1466e

  Copy full SHA for 9d1466e

• wip2

  paulgessinger

  committed
  47ec05e

  Copy full SHA for 47ec05e

• wip

  paulgessinger

  committed
  52dd26c

  Copy full SHA for 52dd26c

• wip

  paulgessinger

  committed
  8ecf99b

  Copy full SHA for 8ecf99b

• some colinear merging works

  paulgessinger

  committed
  b430a4d

  Copy full SHA for b430a4d

• some progress, i'm realizing i need to think more about phi stitching

  paulgessinger

  committed
  12558c4

  Copy full SHA for 12558c4

• wip

  paulgessinger

  committed
  56d568e

  Copy full SHA for 56d568e

• remove gctx

  paulgessinger

  committed
  22d40b1

  Copy full SHA for 22d40b1

• wip

  paulgessinger

  committed
  6ad4bad

  Copy full SHA for 6ad4bad

• updates after BinningValue change

  paulgessinger

  committed
  d15e350

  Copy full SHA for d15e350

• wip

  paulgessinger

  committed
  7e2b729

  Copy full SHA for 7e2b729

• remove gctx, test more of the phi merging

  paulgessinger

  committed
  bbe69d3

  Copy full SHA for bbe69d3

• 1d cylinder merging sort of works

  paulgessinger

  committed
  8197ef9

  Copy full SHA for 8197ef9

• unify axis creation a bit more

  paulgessinger

  committed
  9b20720

  Copy full SHA for 9b20720

• first attempt at 2D grid merging (might need some refactoring)

  paulgessinger

  committed
  6bfb5e0

  Copy full SHA for 6bfb5e0

• expand 1D grid to 2D in preparation for further merging

  paulgessinger

  committed
  425cee3

  Copy full SHA for 425cee3

• fix 2d portal merge memory error, complete tests

  paulgessinger

  committed
  e5fa9da

  Copy full SHA for e5fa9da

• wip

  paulgessinger

  committed
  56d41c3

  Copy full SHA for 56d41c3

• towards full 2D and perpendicular merging

  paulgessinger

  committed
  8cf0803

  Copy full SHA for 8cf0803

• perpendicular cylinder merge works

  paulgessinger

  committed
  aca5823

  Copy full SHA for aca5823

• remove direction from template arguments (can be runtime)

  paulgessinger

  committed
  1496445

  Copy full SHA for 1496445

• fix format

  paulgessinger

  committed
  513fbc8

  Copy full SHA for 513fbc8

• begin work on disc surfaces

  paulgessinger

  committed
  04368a3

  Copy full SHA for 04368a3

• start adding disc tests

  paulgessinger

  committed
  d1356d3

  Copy full SHA for d1356d3

• first disc portal construction tests and shuffling of impl. code

  paulgessinger

  committed
  eea71fd

  Copy full SHA for eea71fd

• fix format

  paulgessinger

  committed
  09af2ba

  Copy full SHA for 09af2ba

• tested disc merging

  paulgessinger

  committed
  fddc9de

  Copy full SHA for fddc9de

• rename 'perpendicular' case to 'parallel'

  paulgessinger

  committed
  c5d82dd

  Copy full SHA for c5d82dd

• support mixed merging

  paulgessinger

  committed
  6011438

  Copy full SHA for 6011438

• portallinks keep a mutable shared ptr for the surface

  paulgessinger

  committed
  9dc9429

  Copy full SHA for 9dc9429

• split portal types up, start implementing conversion

  paulgessinger

  committed
  24d71ad

  Copy full SHA for 24d71ad

• 1d to 2d extension in principle works with existing axes now

  paulgessinger

  committed
  ab40d48

  Copy full SHA for ab40d48

• mixed merging carries over other axis

  paulgessinger

  committed
  cfbf8fd

  Copy full SHA for cfbf8fd

• grid portal filling tested for 2D

  Show description for d6e222e
  paulgessinger

  committed
  d6e222e

  Copy full SHA for d6e222e

• fix format

  paulgessinger

  committed
  3cb3e70

  Copy full SHA for 3cb3e70

• cross merging works including bin contents

  paulgessinger

  committed
  79bd1bd

  Copy full SHA for 79bd1bd

• split up grid merging and rest of .cpp, push content printer to cpp

  paulgessinger

  committed
  712d514

  Copy full SHA for 712d514

• reduce verbosity a bit

  paulgessinger

  committed
  830fa3d

  Copy full SHA for 830fa3d

• some more bin filling testing

  paulgessinger

  committed
  b83a0ca

  Copy full SHA for b83a0ca

• grid construction from trivial working for discs

  paulgessinger

  committed
  159695d

  Copy full SHA for 159695d

• reduce likelihood of surface confusion, fix tests

  paulgessinger

  committed
  30f0a5f

  Copy full SHA for 30f0a5f

• fix a few more cases or order-dependent bin edges

  paulgessinger

  committed
  e4b390a

  Copy full SHA for e4b390a

• migrate merging model away from double dispatch

  Show description for c937fc5
  paulgessinger

  committed
  c937fc5

  Copy full SHA for c937fc5

• avoid one roundtrip method call

  paulgessinger

  committed
  d69ee07

  Copy full SHA for d69ee07

• composite construction including basic flattening

  paulgessinger

  committed
  8284dca

  Copy full SHA for 8284dca

• composite by merging basically works

  paulgessinger

  committed
  da3c638

  Copy full SHA for da3c638

• optimize memory usage at build-time

  paulgessinger

  committed
  b0d0224

  Copy full SHA for b0d0224

• enable composite fallback for grid merging

  paulgessinger

  committed
  b5b1b72

  Copy full SHA for b5b1b72

• accept mutable portal links so we can store them mutably in composite

  Show description for 5da341d
  paulgessinger

  committed
  5da341d

  Copy full SHA for 5da341d

• fixes after dropping operator<< on Surface

  paulgessinger

  committed
  952c6e0

  Copy full SHA for 952c6e0

• remove unneeded code

  paulgessinger

  committed
  9418092

  Copy full SHA for 9418092

• internal storage of volumes becomes mutable

  Show description for 23af824
  paulgessinger

  committed
  23af824

  Copy full SHA for 23af824

• remove unneeded friend declarations

  paulgessinger

  committed
  d121c5a

  Copy full SHA for d121c5a

• cleanup

  paulgessinger

  committed
  a4bb5da

  Copy full SHA for a4bb5da

• split up portallink tests and portal tests

  paulgessinger

  committed
  a14bccf

  Copy full SHA for a14bccf

• link: grid axes are allowed to be open

  paulgessinger

  committed
  8708d48

  Copy full SHA for 8708d48

• link: resolveVolume interface, portal construction

  paulgessinger

  committed
  46a4107

  Copy full SHA for 46a4107

• link: fix: projection from 2D to 1D in grid was missing

  paulgessinger

  committed
  32bfffc

  Copy full SHA for 32bfffc

• link: refactor memory model, more testing of fusing, and error cases

  paulgessinger

  committed
  890b7da

  Copy full SHA for 890b7da

• link: TrivialPortalLink assertion for isOnSurface

  paulgessinger

  committed
  b44bc5e

  Copy full SHA for b44bc5e

• link: GridPortalLink graphical doc comment

  paulgessinger

  committed
  3e39aa0

  Copy full SHA for 3e39aa0

• link: PortalLinkBase is standalone file

  paulgessinger

  committed
  07b0841

  Copy full SHA for 07b0841

• revert: Portal

  paulgessinger

  committed
  4303407

  Copy full SHA for 4303407

• link: surfacePtr returns by reference

  paulgessinger

  committed
  6b36646

  Copy full SHA for 6b36646

• link: PR feedback

  paulgessinger

  committed
  65ca8a7

  Copy full SHA for 65ca8a7

• link: Remove Portal.hpp include

  paulgessinger

  committed
  cd7addf

  Copy full SHA for cd7addf

• link: Pipe through tolerance in resolveVolume

  paulgessinger

  committed
  c717c73

  Copy full SHA for c717c73

• link: Remove visitBins in GridPortalLink

  paulgessinger

  committed
  2a6bf95

  Copy full SHA for 2a6bf95

• link: Add documentation to method

  paulgessinger

  committed
  dfc4b31

  Copy full SHA for dfc4b31

Commits on Aug 23, 2024

• link: resolveVolume returns Result

  paulgessinger

  committed
  b8c7a4e

  Copy full SHA for b8c7a4e

• link: un-document unused parameters

  paulgessinger

  committed
  247306a

  Copy full SHA for 247306a

• link: Fix unit tests after converting from exception to assertions

  Show description for 36ba8a6
  paulgessinger

  committed
  36ba8a6

  Copy full SHA for 36ba8a6

• fix(util): IAxis::visit ensures return

  Show description for d7f93d0
  paulgessinger

  committed
  d7f93d0

  Copy full SHA for d7f93d0

• link: Lint fixes

  paulgessinger

  committed
  5696d1a

  Copy full SHA for 5696d1a

• link: move TrivialPortalLink::toStream to cpp file

  paulgessinger

  committed
  3a57523

  Copy full SHA for 3a57523

• link: work around std::format not being available

  paulgessinger

  committed
  fb072b9

  Copy full SHA for fb072b9

Commits on Aug 26, 2024

• Merge branch 'main' into feat/gen3-portal-links

  paulgessinger

  authored
  779c5ee

  Copy full SHA for 779c5ee

• link: remove extra constructor

  paulgessinger

  committed
  2065f34

  Copy full SHA for 2065f34

• Apply suggestions from code review

  Show description for 5d02f8d
  

  paulgessinger

  and

  andiwand

  authored
  5d02f8d

  Copy full SHA for 5d02f8d

• link: add portal error for composite case

  paulgessinger

  committed
  1ba08e1

  Copy full SHA for 1ba08e1

• link: Make PortalLinkBase constructor explicit

  paulgessinger

  committed
  548df85

  Copy full SHA for 548df85

• link: improve grid extension method name

  paulgessinger

  committed
  1b43cb9

  Copy full SHA for 1b43cb9

• link: Remove funky else case assertion

  paulgessinger

  committed
  bf638df

  Copy full SHA for bf638df

• link: doc / comment updates

  paulgessinger

  committed
  9f713c5

  Copy full SHA for 9f713c5

• link: don't use std::format at all

  paulgessinger

  committed
  280e084

  Copy full SHA for 280e084

• link: make sonar happier

  paulgessinger

  committed
  13a585d

  Copy full SHA for 13a585d

• link: fix shadowed variable, remove explicit captures again

  paulgessinger

  committed
  d8b9b3d

  Copy full SHA for d8b9b3d

• link: Add explicit check for non-null surface

  paulgessinger

  committed
  4a95288

  Copy full SHA for 4a95288

• Merge branch 'main' into feat/gen3-portal-links

  kodiakhq[bot]

  authored
  70a3e83

  Copy full SHA for 70a3e83

• Merge branch 'main' into feat/gen3-portal-links

  kodiakhq[bot]

  authored
  ec1c1db

  Copy full SHA for ec1c1db