Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add counters to propagation summary #3602

Merged

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Sep 10, 2024

This PR adds statistics counters for sensitives, portals and material surfaces to the Propagation summary and adds a little script to plot those.

ITK-sensitive-modules

It also adapts the geomodel.py to recent changes to be able to make this plot.

Changes to references are expected.

@asalzburger asalzburger added this to the next milestone Sep 10, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Sep 10, 2024
@andiwand
Copy link
Contributor

This could be generalized with #3450 but I was not able to follow up with that yet

@asalzburger
Copy link
Contributor Author

This could be generalized with #3450 but I was not able to follow up with that yet

Yes, I actually like the split between "Summary" and "Step" writing, so we have small files for overview checks and big ones for detailed checks.

Copy link

github-actions bot commented Sep 10, 2024

📊: Physics performance monitoring for a72816c

Full contents

physmon summary

@asalzburger asalzburger force-pushed the feat-add-counters-to-propagation-summary branch from df5854f to 2221c71 Compare September 10, 2024 08:20
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small nitpicky comments

Examples/Scripts/Propagation/propagation_summary.py Outdated Show resolved Hide resolved
Examples/Scripts/Propagation/propagation_summary.py Outdated Show resolved Hide resolved
benjaminhuth
benjaminhuth previously approved these changes Sep 12, 2024
@asalzburger
Copy link
Contributor Author

As discussed, I deleted the file.

Copy link

@kodiakhq kodiakhq bot merged commit e590140 into acts-project:main Sep 12, 2024
42 checks passed
@acts-project-service acts-project-service added Breaks Athena build This PR breaks the Athena build Fails Athena tests This PR causes a failure in the Athena tests labels Sep 12, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants