build: Change CMake settings for traccc deps #3620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Infrastructure
stephenswat
force-pushed
the
build/traccc_deps_part_5
branch
2 times, most recently
from
5b91ae2 to
cff4b00
Compare
This commit enables the build of CUDA components of detray, traccc, and vecmem depending on a new `ACTS_TRACCC_ENABLE_CUDA` flag. It also disables the build of the traccc IO code (which has a circular dependency on ACTS) and cleans up the ACTS CMake configuration. Also adds minor fixes to the ways algebra-plugins and detray are loaded (these are temporary workarounds).
|
| @@ -439,14 +440,19 @@ if(ACTS_BUILD_PLUGIN_GEANT4) | |||
| endif() | |||
|
|
|||
| if(ACTS_BUILD_PLUGIN_TRACCC) | |||
| # TODO: Algebra-plugins should set this up itself! | |||
| add_definitions(-DALGEBRA_PLUGINS_INCLUDE_ARRAY) | |||
There was a problem hiding this comment.
This is a global define? Could we define this on the target itself somehow?
There was a problem hiding this comment.
I decided to fix this in acts-project/traccc#704.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables the build of CUDA components of detray, traccc, and vecmem depending on a new
ACTS_TRACCC_ENABLE_CUDAflag. It also disables the build of the traccc IO code (which has a circular dependency on ACTS) and cleans up the ACTS CMake configuration. Also adds minor fixes to the ways algebra-plugins and detray are loaded (these are temporary workarounds).Blocked by: