Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove Sequencer dataflow override #3625

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,6 @@ class Sequencer {
/// Callback that is invoked in the event loop.
/// @warning This function can be called from multiple threads and should therefore be thread-safe
IterationCallback iterationCallback = []() {};
/// Run data flow consistency checks
/// Defaults to false right now until all components are migrated
bool runDataFlowChecks = true;

bool trackFpes = true;
std::vector<FpeMask> fpeMasks{};
Expand Down
4 changes: 0 additions & 4 deletions Examples/Framework/src/Framework/Sequencer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,6 @@ void Sequencer::addElement(const std::shared_ptr<SequenceElement>& element) {
elementTypeCapitalized[0] = std::toupper(elementTypeCapitalized[0]);
ACTS_INFO("Add " << elementType << " '" << element->name() << "'");

if (!m_cfg.runDataFlowChecks) {
return;
}

auto symbol = [&](const char* in) {
std::string s = demangleAndShorten(in);
std::size_t pos = 0;
Expand Down
1 change: 0 additions & 1 deletion Examples/Python/src/Framework.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ void addFramework(Context& ctx) {
ACTS_PYTHON_MEMBER(fpeMasks);
ACTS_PYTHON_MEMBER(failOnFirstFpe);
ACTS_PYTHON_MEMBER(fpeStackTraceLength);
ACTS_PYTHON_MEMBER(runDataFlowChecks);
ACTS_PYTHON_STRUCT_END();

auto fpem =
Expand Down
Loading