Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Timed Clusterization #3654

Merged
merged 7 commits into from
Oct 4, 2024
Merged

feat: Add support for Timed Clusterization #3654

merged 7 commits into from
Oct 4, 2024

Conversation

CarloVarni
Copy link
Collaborator

This add possibility of doing clusterization using as well time information

@CarloVarni CarloVarni added this to the v37.0.0 milestone Sep 27, 2024
@CarloVarni CarloVarni requested a review from gagnonlg September 27, 2024 11:11
@github-actions github-actions bot added Component - Core Affects the Core module Clustering labels Sep 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 27, 2024 •
edited
Loading

📊: Physics performance monitoring for 23f4530

Full contents

physmon summary

@CarloVarni CarloVarni force-pushed the TimeClustering branch 2 times, most recently from aef68d5 to dccb876 Compare October 2, 2024 10:28
gagnonlg
gagnonlg suggested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@gagnonlg gagnonlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @CarloVarni , I only have a few comments

Core/include/Acts/Clusterization/TimedClusterization.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Clusterization/TimedClusterization.hpp Show resolved Hide resolved
Core/include/Acts/Clusterization/TimedClusterization.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Clusterization/TimedClusterization.ipp Outdated Show resolved Hide resolved
gagnonlg
gagnonlg approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@gagnonlg gagnonlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 6cea6b2 into acts-project:main Oct 4, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Oct 4, 2024
@CarloVarni CarloVarni deleted the TimeClustering branch October 4, 2024 17:32
@acts-project-service
Copy link
Collaborator

acts-project-service commented Oct 4, 2024 •
edited
Loading

🔴 Athena integration test results [6cea6b2]

🔴 Some tests have failed!

Please investigate the pipeline!

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🔴 run_workflow_tests_run4_mc
🔴 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsCachedWorkflow
🟢 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_unit_tests

@acts-project-service acts-project-service added Breaks Athena build This PR breaks the Athena build Fails Athena tests This PR causes a failure in the Athena tests labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger left review comments

@gagnonlg gagnonlg gagnonlg approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Clustering Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Milestone
v37.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@CarloVarni @acts-project-service @paulgessinger @gagnonlg