feat: Conversion and chain code in traccc #3656

stephenswat · 2024-09-27T13:05:06Z

This PR adds conversion code as well as the code to run simple host-side chain algorithms using traccc.

This code is highly experimental and perhaps not yet of the highest possible quality; I intend to iterate on this later, but I'd like to get the skeleton in to somewhat stabilize this plugin.

Closes #3281, #3320, #3363, #3505.

stephenswat · 2024-09-27T13:05:19Z

A little weekend gift for @asalzburger

github-actions · 2024-09-29T05:46:13Z

📊: Physics performance monitoring for `a0c9c25`

Full contents

physmon summary

sonarqubecloud · 2024-09-29T09:17:32Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 25%)
1 New Bugs (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)
0.0% Line Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Examples/Python/src/Traccc.cpp

paulgessinger · 2024-09-30T07:55:35Z

Examples/Python/src/Traccc.cpp

-
-  auto traccc = mex.def_submodule("traccc");
+  auto [_, mex] = ctx.get("main", "examples");
+  auto m = mex.def_submodule("_traccc");


Does this run the code that adds a submodule multiple times?

We anyway need to streamline a bit the python bindings and make it somewhat consistent.

stephenswat · 2024-10-15T10:58:20Z

@asalzburger this is now ready for review.

This PR adds conversion code as well as the code to run simple host-side chain algorithms using traccc. Co-authored-by: Stephen Nicholas Swatman <[email protected]>

coderabbitai · 2024-11-15T16:24:45Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

stephenswat · 2024-11-15T16:31:19Z

Omg coderabbit 🥺👉👈

andiwand

first quick round

andiwand · 2024-12-09T13:00:08Z

Examples/Algorithms/Traccc/Common/src/Conversion/CellMapConversion.cpp

+
+namespace ActsExamples::Traccc::Common::Conversion {
+
+std::map<Acts::GeometryIdentifier, std::vector<traccc::cell>> tracccCellsMap(


I usually bind the namespace explicitly to the definition to avoid late linker errors in case the signature changes

andiwand · 2024-12-09T13:01:03Z

Examples/Algorithms/Traccc/Common/include/ActsExamples/Traccc/Conversion/CellMapConversion.hpp

+
+#include "traccc/edm/cell.hpp"
+
+namespace ActsExamples::Traccc::Common::Conversion {


That looks quite deeply nested. I think we usually try to keep things flap. But nothing critical.

andiwand · 2024-12-09T13:02:21Z

...es/Algorithms/Traccc/Common/include/ActsExamples/Traccc/Conversion/MeasurementConversion.hpp

+template <typename detector_t, std::forward_iterator iterator_t>
+inline MeasurementContainer convertTracccToActsMeasurements(
+    const detector_t& detector, iterator_t measurements_begin,
+    iterator_t measurements_end) {


nitpick: could be a range instead of begin and end

andiwand · 2024-12-09T13:03:43Z

Examples/Algorithms/Traccc/Common/include/ActsExamples/Traccc/Conversion/MeasurementMap.hpp

+
+namespace ActsExamples::Traccc::Common::Conversion {
+
+namespace {


is it intentional that everything lives in an anonymous namespace here?

andiwand · 2024-12-09T13:05:34Z

Examples/Algorithms/Traccc/Common/include/ActsExamples/Traccc/TracccChainConfig.hpp

+
+namespace ActsExamples::Traccc::Common {
+
+struct TracccChainConfig {


nitpick: usually we put the config inline with the algorithm

andiwand · 2024-12-09T13:07:53Z

Examples/Python/tests/test_examples.py

-    ids=["smeared", "geometric"],
+    ids=["smeared", "geometric", "odd-smeared", "odd-geometric"],


should this be a replacement?

andiwand · 2024-12-09T13:08:37Z

Examples/Scripts/Python/traccc_host.py

+# def create_gen1_tracking_geometry():
+#     return getOpenDataDetector()
+
+# def create_gen2_tracking_geometry():


github-actions bot added Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation labels Sep 27, 2024

stephenswat force-pushed the feat/traccc_host branch 4 times, most recently from cebf42a to ba45053 Compare September 29, 2024 04:50

stephenswat force-pushed the feat/traccc_host branch 2 times, most recently from cd6a697 to ea15a01 Compare September 29, 2024 07:26

paulgessinger reviewed Sep 30, 2024

View reviewed changes

Examples/Python/src/Traccc.cpp Outdated Show resolved Hide resolved

paulgessinger reviewed Sep 30, 2024

View reviewed changes

stephenswat force-pushed the feat/traccc_host branch from ea15a01 to a0c9c25 Compare September 30, 2024 08:46

github-actions bot added the Event Data Model label Sep 30, 2024

stephenswat force-pushed the feat/traccc_host branch from a0c9c25 to 53d156e Compare October 15, 2024 10:57

github-actions bot added Component - Core Affects the Core module and removed Event Data Model labels Oct 15, 2024

stephenswat force-pushed the feat/traccc_host branch from 53d156e to b81993e Compare October 15, 2024 10:59

github-actions bot removed the Component - Documentation Affects the documentation label Oct 15, 2024

stephenswat force-pushed the feat/traccc_host branch 5 times, most recently from e8cf174 to 5db1acd Compare October 15, 2024 11:14

github-actions bot removed the Component - Core Affects the Core module label Oct 15, 2024

feat: Conversion and chain code in traccc

5db1acd

This PR adds conversion code as well as the code to run simple host-side chain algorithms using traccc. Co-authored-by: Stephen Nicholas Swatman <[email protected]>

Merge branch 'main' into feat/traccc_host

213a663

andiwand self-requested a review December 7, 2024 14:23

andiwand reviewed Dec 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Conversion and chain code in traccc #3656

feat: Conversion and chain code in traccc #3656

stephenswat commented Sep 27, 2024

stephenswat commented Sep 27, 2024

github-actions bot commented Sep 29, 2024 •

edited

Loading

sonarqubecloud bot commented Sep 29, 2024

paulgessinger Sep 30, 2024

asalzburger Sep 30, 2024

stephenswat commented Oct 15, 2024

coderabbitai bot commented Nov 15, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

stephenswat commented Nov 15, 2024

andiwand left a comment

andiwand Dec 9, 2024

andiwand Dec 9, 2024

andiwand Dec 9, 2024

andiwand Dec 9, 2024

andiwand Dec 9, 2024

andiwand Dec 9, 2024

andiwand Dec 9, 2024


		namespace ActsExamples::Traccc::Common::Conversion {

		std::map<Acts::GeometryIdentifier, std::vector<traccc::cell>> tracccCellsMap(


		#include "traccc/edm/cell.hpp"

		namespace ActsExamples::Traccc::Common::Conversion {


		namespace ActsExamples::Traccc::Common::Conversion {

		namespace {


		namespace ActsExamples::Traccc::Common {

		struct TracccChainConfig {

		ids=["smeared", "geometric"],
		ids=["smeared", "geometric", "odd-smeared", "odd-geometric"],

feat: Conversion and chain code in traccc #3656

Are you sure you want to change the base?

feat: Conversion and chain code in traccc #3656

Conversation

stephenswat commented Sep 27, 2024

stephenswat commented Sep 27, 2024

github-actions bot commented Sep 29, 2024 • edited Loading

📊: Physics performance monitoring for a0c9c25

physmon summary

sonarqubecloud bot commented Sep 29, 2024

Quality Gate failed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephenswat commented Oct 15, 2024

coderabbitai bot commented Nov 15, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

stephenswat commented Nov 15, 2024

andiwand left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2024 •

edited

Loading

📊: Physics performance monitoring for `a0c9c25`

CodeRabbit Configuration File (`.coderabbit.yaml`)