refactor!: Middle range strategy #3719
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
| @@ -1,3 +1,4 @@ | |||
| // -*- C++ -*- | |||
| namespace Acts::SeedFinding { | ||
| /// @brief enum to define how to check the Radial range for middle space-point | ||
| /// used in the Seed Finding process | ||
| enum MiddleRadialStrategy : int { |
There was a problem hiding this comment.
Suggested change
| enum MiddleRadialStrategy : int { | |
| enum class MiddleRadialStrategy : int { |
Comment on lines
820
to
821
| switch(m_config.middleRangeStrategy) { | ||
| case Acts::SeedFinding::MiddleRadialStrategy::RelyOnGrid: |
There was a problem hiding this comment.
Suggested change
| switch(m_config.middleRangeStrategy) { | |
| case Acts::SeedFinding::MiddleRadialStrategy::RelyOnGrid: | |
| switch(m_config.middleRangeStrategy) { | |
| using enum Acts::SeedFinding::MiddleRadialStrategy; | |
| case RelyOnGrid: |
etc
CarloVarni
changed the title
added 2 commits
October 14, 2024 00:24
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes:
SeedFinderConfig: (1) Defining an enumActs::SeedFinding::MiddleRadialStrategy(instead of relying on a series of flags) for defining a strategy to constrain the middle space point radius (2) removing un-used variables (3) move some variables away since they were used ONLY in the example SeedingAlgorithmSeedFinders, where now the user provides the radius range via theSeedFinderOptionsinstead of passing aActs::Range1D<float>tocreateSeedsForGroup