fix: Track selector printouts to be in line with actual cuts #3815
Conversation
WalkthroughEnhancements to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
pbutti
changed the title
Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
Core/include/Acts/TrackFinding/TrackSelector.hpp (2)
307-318: Hmmmm, well structured these lambda functions are!Clear separation of printing patterns, you have achieved. Improved readability, this brings to our codebase.
A small suggestion, I have. Add comments to explain when each lambda should be used:
- // for printing cuts set up with `within` + // For printing bounded cuts with both minimum and maximum values (e.g., "min <= value < max") - // for printing cuts set up with `checkMin` + // For printing lower-bounded cuts (e.g., "min <= value") - // for printing cuts set up with `checkMax` + // For printing upper-bounded cuts (e.g., "value <= max")
320-332: Wise choice of printing functions for each cut type, this is!Match the actual cut checks in
isValidTrack, these printouts now do. But a small suggestion for improvement, I have.Group the printouts to match the order in
isValidTrackmethod, we should. Apply this change:printMinMax("loc0", cuts.loc0Min, cuts.loc0Max); printMinMax("loc1", cuts.loc1Min, cuts.loc1Max); - printMinMax("time", cuts.timeMin, cuts.timeMax); printMinMax("phi", cuts.phiMin, cuts.phiMax); printMinMax("eta", cuts.etaMin, cuts.etaMax); printMinMax("absEta", cuts.absEtaMin, cuts.absEtaMax); printMinMax("pt", cuts.ptMin, cuts.ptMax); + printMinMax("time", cuts.timeMin, cuts.timeMax); printMax("nHoles", cuts.maxHoles); printMax("nOutliers", cuts.maxOutliers); printMax("nHoles + nOutliers", cuts.maxHolesAndOutliers); printMax("nSharedHits", cuts.maxSharedHits); printMax("chi2", cuts.maxChi2); printMin("nMeasurements", cuts.minMeasurements);This order, it matches the validation sequence in
isValidTrackmethod, hmm yes.
|
…oject#3815) Minor fix to the printouts in the track selector to show the right limits applied to the counters. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced output clarity with new printing functions for cut values in track selection. - Added validation checks for `etaMax` parameter and improved error handling for bin indexing. - **Bug Fixes** - Updated logic for evaluating track validity to ensure accurate results. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…oject#3815) Minor fix to the printouts in the track selector to show the right limits applied to the counters. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced output clarity with new printing functions for cut values in track selection. - Added validation checks for `etaMax` parameter and improved error handling for bin indexing. - **Bug Fixes** - Updated logic for evaluating track validity to ensure accurate results. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Minor fix to the printouts in the track selector to show the right limits applied to the counters.
Summary by CodeRabbit
New Features
etaMaxparameter and improved error handling for bin indexing.Bug Fixes