feat(util): Add `overloaded` helper #3816

paulgessinger · 2024-11-06T13:25:01Z

This is useful in combination with std::visit. With this, you can do something like

  struct A {};
  std::variant<int, double, A> var;

  var = 42;

  std::visit(overloaded{
                 [](int) { BOOST_CHECK(true); },
                 [](double) { BOOST_CHECK(false); },
                 [](A) { BOOST_CHECK(false); },
             },
             var);

which can be convenient.

I'm using this in #3869

This is useful in combination with `std::visit`.

coderabbitai · 2024-11-06T13:25:11Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-11-06T18:36:01Z

📊: Physics performance monitoring for `0ed09f6`

Full contents

physmon summary

AJPfleger

This looks useful, but do we have an actual use-case for this?

paulgessinger · 2024-11-12T07:36:06Z

I have a usage in the upcoming blueprint PR.

paulgessinger · 2024-11-18T13:41:49Z

@AJPfleger Objections?

AJPfleger · 2024-11-18T13:44:13Z

looks good, could you just link the blueprint-PR?

paulgessinger · 2024-11-18T15:31:31Z

@AJPfleger That's not ready yet

paulgessinger · 2024-11-22T07:30:42Z

@AJPfleger can you have another look now?

sonarqubecloud · 2024-11-22T12:49:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

acts-project-service · 2024-11-22T13:17:40Z

🔴 Athena integration test results [`edad4c9`]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job	report
🟢	report_pull_request
🟢	run_art_test: test_run4_acts_vertex_PU200
🟢	run_art_test: test_run4_ttbar_PU200
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	test_ActsDumpGeometryIdentifiers
🔴	test_ActsCheckObjectCountsWorkflowHgtd
🟢	test_ActsCheckObjectCountsCachedWorkflow
🟢	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflowCached
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_unit_tests

This PR implements building a tracking geometry using the blueprint building mechanism. ``` +---------------+ +-----------+ | | | | | Root | | v | | | +---------------+ +---------------+ | | | | | | Child 1 | +----------+ | | | v +----------+ +---------------+ +---------------+ | | | +--------------+ | Child 2 | v +----------+ | | .---------. | | +---------------+ / \ | v ( Proc node ) | +---------------+ `. ,' | | | `-------' | | Child 3 | | | | | | | +---------------+ +---------+ ``` The construction phases are documented in @c BlueprintNode, which is the base class for all nodes in the tree. Part of: - #3502 Blocked by: - #3816 - #3818 - #3971

feat(util): Add overloaded helper

35f0231

This is useful in combination with `std::visit`.

github-actions bot added the Component - Core Affects the Core module label Nov 6, 2024

paulgessinger added this to the next milestone Nov 6, 2024

fix missing include

a93a7c5

paulgessinger requested review from AJPfleger and andiwand November 11, 2024 17:27

AJPfleger reviewed Nov 11, 2024

View reviewed changes

paulgessinger mentioned this pull request Nov 18, 2024

feat: Gen3 blueprint geometry construction #3869

Merged

Merge branch 'main' into feat/overloaded

1b1d290

andiwand approved these changes Nov 22, 2024

View reviewed changes

andiwand added the automerge label Nov 22, 2024

kodiakhq bot added 2 commits November 22, 2024 09:32

Merge branch 'main' into feat/overloaded

711aac7

Merge branch 'main' into feat/overloaded

0ed09f6

kodiakhq bot merged commit edad4c9 into acts-project:main Nov 22, 2024
44 checks passed

github-actions bot removed the automerge label Nov 22, 2024

acts-project-service added Breaks Athena build This PR breaks the Athena build Fails Athena tests This PR causes a failure in the Athena tests labels Nov 22, 2024

paulgessinger modified the milestones: next, v38.0.0 Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(util): Add `overloaded` helper #3816

feat(util): Add `overloaded` helper #3816

paulgessinger commented Nov 6, 2024 •

edited

Loading

coderabbitai bot commented Nov 6, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Nov 6, 2024 •

edited

Loading

AJPfleger left a comment

paulgessinger commented Nov 12, 2024

paulgessinger commented Nov 18, 2024

AJPfleger commented Nov 18, 2024

paulgessinger commented Nov 18, 2024

paulgessinger commented Nov 22, 2024

sonarqubecloud bot commented Nov 22, 2024

acts-project-service commented Nov 22, 2024 •

edited

Loading

feat(util): Add overloaded helper #3816

feat(util): Add overloaded helper #3816

Conversation

paulgessinger commented Nov 6, 2024 • edited Loading

coderabbitai bot commented Nov 6, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Nov 6, 2024 • edited Loading

📊: Physics performance monitoring for 0ed09f6

physmon summary

AJPfleger left a comment

Choose a reason for hiding this comment

paulgessinger commented Nov 12, 2024

paulgessinger commented Nov 18, 2024

AJPfleger commented Nov 18, 2024

paulgessinger commented Nov 18, 2024

paulgessinger commented Nov 22, 2024

sonarqubecloud bot commented Nov 22, 2024

Quality Gate passed

acts-project-service commented Nov 22, 2024 • edited Loading

🔴 Athena integration test results [edad4c9]

🔴 Some tests have failed!

feat(util): Add `overloaded` helper #3816

feat(util): Add `overloaded` helper #3816

paulgessinger commented Nov 6, 2024 •

edited

Loading

coderabbitai bot commented Nov 6, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Nov 6, 2024 •

edited

Loading

📊: Physics performance monitoring for `0ed09f6`

acts-project-service commented Nov 22, 2024 •

edited

Loading

🔴 Athena integration test results [`edad4c9`]