Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use true start params for fitters in Examples Physmon #3915

Closed
wants to merge 4 commits into from
Closed

test: Use true start params for fitters in Examples Physmon #3915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
265f188
test: Use true start params for fitters in Examples Physmon
andiwand Nov 27, 2024
28bd3e9
add zeros shorthand
andiwand Nov 27, 2024
d217c79
fix
andiwand Nov 27, 2024
7662443
increase stats
andiwand Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions CI/physmon/workflows/physmon_trackfinding_1muon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,19 +91,6 @@ def run_ckf_tracking(label, seeding):
s,
setup.trackingGeometry,
setup.field,
ParticleSmearingSigmas( # only used by SeedingAlgorithm.TruthSmeared
# zero eveything so the CKF has a chance to find the measurements
d0=0,
d0PtA=0,
d0PtB=0,
z0=0,
z0PtA=0,
z0PtB=0,
t0=0,
phi=0,
theta=0,
ptRel=0,
),
SeedFinderConfigArg(
r=(33 * u.mm, 200 * u.mm),
deltaR=(1 * u.mm, 60 * u.mm),
Expand All @@ -118,6 +105,9 @@ def run_ckf_tracking(label, seeding):
SeedFinderOptionsArg(bFieldInZ=2 * u.T),
TruthEstimatedSeedingAlgorithmConfigArg(deltaR=(10.0 * u.mm, None)),
seedingAlgorithm=seeding,
# only used by SeedingAlgorithm.TruthSmeared
# zero eveything so the fitter has a chance to find the measurements
particleSmearingSigmas=ParticleSmearingSigmas.zeros(),
initialSigmas=[
1 * u.mm,
1 * u.mm,
Expand Down
2 changes: 1 addition & 1 deletion CI/physmon/workflows/physmon_trackfitting_gsf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

with tempfile.TemporaryDirectory() as temp:
s = acts.examples.Sequencer(
events=10000,
events=100000,
numThreads=-1,
logLevel=acts.logging.INFO,
)
Expand Down
2 changes: 1 addition & 1 deletion CI/physmon/workflows/physmon_trackfitting_gx2f.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

with tempfile.TemporaryDirectory() as temp:
s = acts.examples.Sequencer(
events=10000,
events=100000,
numThreads=-1,
logLevel=acts.logging.INFO,
)
Expand Down
2 changes: 1 addition & 1 deletion CI/physmon/workflows/physmon_trackfitting_kf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

with tempfile.TemporaryDirectory() as temp:
s = acts.examples.Sequencer(
events=10000,
events=100000,
numThreads=-1,
logLevel=acts.logging.INFO,
)
Expand Down
13 changes: 13 additions & 0 deletions Examples/Python/python/acts/examples/reconstruction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,19 @@
defaults=[None] * 10,
)

ParticleSmearingSigmas.zeros = lambda: ParticleSmearingSigmas(
d0=0.0,
d0PtA=0.0,
d0PtB=0.0,
z0=0.0,
z0PtA=0.0,
z0PtB=0.0,
t0=0.0,
phi=0.0,
theta=0.0,
ptRel=0.0,
)

SeedFinderConfigArg = namedtuple(
"SeedFinderConfig",
[
Expand Down
16 changes: 3 additions & 13 deletions Examples/Scripts/Optimization/ckf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,19 +188,6 @@ def runCKFTracks(
s,
trackingGeometry,
field,
ParticleSmearingSigmas( # only used by SeedingAlgorithm.TruthSmeared
# zero eveything so the CKF has a chance to find the measurements
d0=0,
d0PtA=0,
d0PtB=0,
z0=0,
z0PtA=0,
z0PtB=0,
t0=0,
phi=0,
theta=0,
ptRel=0,
),
SeedFinderConfigArg(
r=(None, 200 * u.mm), # rMin=default, 33mm
deltaR=(DeltaRMin * u.mm, DeltaRMax * u.mm),
Expand All @@ -225,6 +212,9 @@ def runCKFTracks(
else SeedingAlgorithm.Default
)
),
# only used by SeedingAlgorithm.TruthSmeared
# zero eveything so the fitter has a chance to find the measurements
particleSmearingSigmas=ParticleSmearingSigmas.zeros(),
initialSigmas=[
1 * u.mm,
1 * u.mm,
Expand Down
16 changes: 3 additions & 13 deletions Examples/Scripts/Python/ckf_tracks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,19 +99,6 @@ def runCKFTracks(
s,
trackingGeometry,
field,
ParticleSmearingSigmas( # only used by SeedingAlgorithm.TruthSmeared
# zero eveything so the CKF has a chance to find the measurements
d0=0,
d0PtA=0,
d0PtB=0,
z0=0,
z0PtA=0,
z0PtB=0,
t0=0,
phi=0,
theta=0,
ptRel=0,
),
SeedFinderConfigArg(
r=(None, 200 * u.mm), # rMin=default, 33mm
deltaR=(1 * u.mm, 60 * u.mm),
Expand All @@ -134,6 +121,9 @@ def runCKFTracks(
else SeedingAlgorithm.Default
)
),
# only used by SeedingAlgorithm.TruthSmeared
# zero eveything so the fitter has a chance to find the measurements
particleSmearingSigmas=ParticleSmearingSigmas.zeros(),
initialSigmas=[
1 * u.mm,
1 * u.mm,
Expand Down
13 changes: 13 additions & 0 deletions Examples/Scripts/Python/truth_tracking_gsf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ def runTruthTrackingGsf(
from acts.examples.reconstruction import (
addSeeding,
SeedingAlgorithm,
ParticleSmearingSigmas,
addTruthTrackingGsf,
)

Expand Down Expand Up @@ -100,6 +101,18 @@ def runTruthTrackingGsf(
rnd=rnd,
inputParticles="particles_input",
seedingAlgorithm=SeedingAlgorithm.TruthSmeared,
# zero eveything so the fitter has a chance to find the measurements
particleSmearingSigmas=ParticleSmearingSigmas.zeros(),
initialSigmas=[
1 * u.mm,
1 * u.mm,
1 * u.degree,
1 * u.degree,
0.1 * u.e / u.GeV,
1 * u.ns,
],
initialSigmaPtRel=0.01,
initialVarInflation=[1.0] * 6,
particleHypothesis=acts.ParticleHypothesis.electron,
)

Expand Down
13 changes: 13 additions & 0 deletions Examples/Scripts/Python/truth_tracking_gx2f.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def runTruthTrackingGx2f(
from acts.examples.reconstruction import (
addSeeding,
SeedingAlgorithm,
ParticleSmearingSigmas,
addGx2fTracks,
)

Expand Down Expand Up @@ -97,6 +98,18 @@ def runTruthTrackingGx2f(
rnd=rnd,
inputParticles="particles_input",
seedingAlgorithm=SeedingAlgorithm.TruthSmeared,
# zero eveything so the fitter has a chance to find the measurements
particleSmearingSigmas=ParticleSmearingSigmas.zeros(),
initialSigmas=[
1 * u.mm,
1 * u.mm,
1 * u.degree,
1 * u.degree,
0.1 * u.e / u.GeV,
1 * u.ns,
],
initialSigmaPtRel=0.01,
initialVarInflation=[1.0] * 6,
particleHypothesis=acts.ParticleHypothesis.muon,
)

Expand Down
13 changes: 13 additions & 0 deletions Examples/Scripts/Python/truth_tracking_kalman.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def runTruthTrackingKalman(
from acts.examples.reconstruction import (
addSeeding,
SeedingAlgorithm,
ParticleSmearingSigmas,
addKalmanTracks,
)

Expand Down Expand Up @@ -115,6 +116,18 @@ def runTruthTrackingKalman(
rnd=rnd,
inputParticles="particles_input",
seedingAlgorithm=SeedingAlgorithm.TruthSmeared,
# zero eveything so the fitter has a chance to find the measurements
particleSmearingSigmas=ParticleSmearingSigmas.zeros(),
initialSigmas=[
1 * u.mm,
1 * u.mm,
1 * u.degree,
1 * u.degree,
0.1 * u.e / u.GeV,
1 * u.ns,
],
initialSigmaPtRel=0.01,
initialVarInflation=[1.0] * 6,
particleHypothesis=acts.ParticleHypothesis.muon,
)

Expand Down
Loading