Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove final on template derived classes #3923

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix: Remove final on template derived classes #3923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62ebd04
fix: Remove `final` on teplate derived classes
paulgessinger Nov 29, 2024
01fe523
Merge branch 'main' into fix/remove-final
kodiakhq[bot] Nov 29, 2024
cf7db32
Merge branch 'main' into fix/remove-final
AJPfleger Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/include/Acts/Geometry/GridPortalLink.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ class GridPortalLink : public PortalLinkBase {
/// @tparam Axes The axis types of the grid
template <typename... Axes>
requires(sizeof...(Axes) <= 2)
class GridPortalLinkT final : public GridPortalLink {
class GridPortalLinkT : public GridPortalLink {
public:
/// The internal grid type
using GridType = Grid<const TrackingVolume*, Axes...>;
Expand Down
4 changes: 2 additions & 2 deletions Core/include/Acts/Utilities/Axis.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class NeighborHoodIndices {
/// This class provides some basic functionality for calculating bin indices
/// for a given equidistant binning.
template <AxisBoundaryType bdt>
class Axis<AxisType::Equidistant, bdt> final : public IAxis {
class Axis<AxisType::Equidistant, bdt> : public IAxis {
public:
static constexpr AxisType type = AxisType::Equidistant;

Expand Down Expand Up @@ -417,7 +417,7 @@ class Axis<AxisType::Equidistant, bdt> final : public IAxis {
/// This class provides some basic functionality for calculating bin indices
/// for a given binning with variable bin sizes.
template <AxisBoundaryType bdt>
class Axis<AxisType::Variable, bdt> final : public IAxis {
class Axis<AxisType::Variable, bdt> : public IAxis {
public:
static constexpr AxisType type = AxisType::Variable;

Expand Down
6 changes: 3 additions & 3 deletions Core/include/Acts/Utilities/GridAccessHelpers.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class IBoundToGridLocal {
};

template <typename global_to_grid_local_t>
class Affine3Transformed final : public IGlobalToGridLocal {
class Affine3Transformed : public IGlobalToGridLocal {
public:
using grid_local_t = typename global_to_grid_local_t::grid_local_t;

Expand Down Expand Up @@ -142,7 +142,7 @@ class Affine3Transformed final : public IGlobalToGridLocal {
/// position
/// @tparam ...Args
template <BinningValue... Args>
class GlobalSubspace final : public IGlobalToGridLocal {
class GlobalSubspace : public IGlobalToGridLocal {
public:
using grid_local_t = std::array<double, sizeof...(Args)>;

Expand Down Expand Up @@ -179,7 +179,7 @@ class GlobalSubspace final : public IGlobalToGridLocal {
// The bound to grid local transformation, if only access of a subspace
// is requested
template <std::size_t... Args>
class LocalSubspace final : public IBoundToGridLocal {
class LocalSubspace : public IBoundToGridLocal {
public:
using grid_local_t = std::array<double, sizeof...(Args)>;

Expand Down
Loading