fix!: Make BinUtility constructor explicit #3953
Open
ci-bridge / CI Bridge / clang_tidy
succeeded
Dec 5, 2024 in 56m 1s
GitLab CI: SUCCESS
This check triggered job acts/ci-bridge/47616543
in pipeline acts/ci-bridge/25114
Status: SUCCESS
Created at: 2024-12-05T16:46:15.772+01:00
Started at: 2024-12-05T18:10:03.775+01:00
Finished at: 2024-12-05T19:06:04.250+01:00
Details
Showing last 839 out of 43215 total lines
93 | const configuration_t &, typename backend_t::owning_data_t && b
| ^
| /*unused*/
/builds/acts/ci-bridge/src/build/_deps/covfie-src/lib/core/covfie/core/backend/transformer/linear.hpp:171:35: warning: implicit conversion
'std::size_t' (aka 'unsigned long') -> 'bool' [readability-implicit-bool-conversion]
171 | i + ((n & 4) ? 1 : 0)
| ^
| ( != 0u)
/builds/acts/ci-bridge/src/build/_deps/covfie-src/lib/core/covfie/core/backend/transformer/linear.hpp:175:35: warning: implicit conversion
'std::size_t' (aka 'unsigned long') -> 'bool' [readability-implicit-bool-conversion]
175 | j + ((n & 2) ? 1 : 0)
| ^
| ( != 0u)
/builds/acts/ci-bridge/src/build/_deps/covfie-src/lib/core/covfie/core/backend/transformer/linear.hpp:179:35: warning: implicit conversion
'std::size_t' (aka 'unsigned long') -> 'bool' [readability-implicit-bool-conversion]
179 | k + ((n & 1) ? 1 : 0)
| ^
| ( != 0u)
/builds/acts/ci-bridge/src/build/_deps/covfie-src/lib/core/covfie/core/parameter_pack.hpp:27:5: warning: use '= default' to define a trivial default
constructor [modernize-use-equals-default]
27 | parameter_pack()
| ^
28 | {
| ~
| = default;
29 | }
| ~
/builds/acts/ci-bridge/src/build/_deps/covfie-src/lib/core/covfie/core/utility/binary_io.hpp:73:14: warning: variable 'hdr1' is not initialized
[cppcoreguidelines-init-variables]
73 | uint32_t hdr1, hdr2;
| ^
| = 0
/builds/acts/ci-bridge/src/build/_deps/covfie-src/lib/core/covfie/core/utility/binary_io.hpp:73:20: warning: variable 'hdr2' is not initialized
[cppcoreguidelines-init-variables]
73 | uint32_t hdr1, hdr2;
| ^
| = 0
/builds/acts/ci-bridge/src/build/_deps/covfie-src/lib/core/covfie/core/utility/nd_map.hpp:19:42: warning: all parameters should be named in a function
[readability-named-parameter]
19 | auto tail_impl(std::index_sequence<Ns...>, [[maybe_unused]] std::tuple<Ts...> t)
| ^
| /*unused*/
[ninja] [1442/1452] Linking CXX executable bin/ActsUnitTestCovfieFieldConversion
[ninja] [1443/1452] Building CXX object Tests/UnitTests/Plugins/Hashing/CMakeFiles/ActsUnitTestHashingSeedingTest.dir/HashingSeedingTest.cpp.o
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:133:7: warning: implicit conversion 'char **' -> 'bool' [readability-
implicit-bool-conversion]
133 | if (error) {
| ^
| != nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:134:14: warning: C-style casts are discouraged; use static_cast [google-
readability-casting]
134 | *error = (char *)malloc(256); // TODO: win doesn't support snprintf
| ^~~~~~~~
| static_cast<char *>( )
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:145:7: warning: implicit conversion 'char **' -> 'bool' [readability-
implicit-bool-conversion]
145 | if (error) {
| ^
| != nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:146:14: warning: C-style casts are discouraged; use static_cast [google-
readability-casting]
146 | *error = (char *)malloc(strlen(msg) + 1);
| ^~~~~~~~
| static_cast<char *>( )
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:177:10: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
177 | return (Node*)((uint8_t *)_nodes + (_s * i));
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:177:18: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
177 | return (Node*)((uint8_t *)_nodes + (_s * i));
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:194:30: warning: statement should be inside braces [readability-braces-
around-statements]
194 | for (int i = 0; i < f; i++)
| ^
| {
195 | d += fabs(x[i] - y[i]);
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:436:34: warning: statement should be inside braces [readability-braces-
around-statements]
436 | for (int z = 0; z < f; z++)
| ^
| {
437 | p->v[z] = (p->v[z] * ic + nodes[k]->v[z] / norm) / (ic + 1);
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:441:34: warning: statement should be inside braces [readability-braces-
around-statements]
441 | for (int z = 0; z < f; z++)
| ^
| {
442 | q->v[z] = (q->v[z] * jc + nodes[k]->v[z] / norm) / (jc + 1);
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:471:34: warning: statement should be inside braces [readability-braces-
around-statements]
471 | for (int z = 0; z < f; z++)
| ^
| {
472 | node->v[z] /= norm;
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:510:18: warning: statement should be inside braces [readability-braces-
around-statements]
510 | if (ppqq > 0) return 2.0 - 2.0 * pq / sqrt(ppqq);
| ^
| {
511 | else return 2.0; // cos is 0
| }
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:511:9: warning: statement should be inside braces [readability-braces-
around-statements]
511 | else return 2.0; // cos is 0
| ^
| {
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:520:18: warning: statement should be inside braces [readability-braces-
around-statements]
520 | if (dot != 0)
| ^
| {
521 | return (dot > 0);
522 | else
| }
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:522:9: warning: statement should be inside braces [readability-braces-
around-statements]
522 | else
| ^
| {
523 | return (bool)random.flip();
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:523:14: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
523 | return (bool)random.flip();
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:527:21: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
527 | Node<S, T>* p = (Node<S, T>*)alloca(s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:528:21: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
528 | Node<S, T>* q = (Node<S, T>*)alloca(s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:530:32: warning: statement should be inside braces [readability-braces-
around-statements]
530 | for (int z = 0; z < f; z++)
| ^
| {
531 | n->v[z] = p->v[z] - q->v[z];
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:543:23: warning: statement should be inside braces [readability-braces-
around-statements]
543 | if (child_nr == 0)
| ^
| {
544 | margin = -margin;
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:598:21: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
598 | Node<S, T>* p = (Node<S, T>*)alloca(s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:599:21: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
599 | Node<S, T>* q = (Node<S, T>*)alloca(s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:603:32: warning: statement should be inside braces [readability-braces-
around-statements]
603 | for (int z = 0; z < f; z++)
| ^
| {
604 | n->v[z] = p->v[z] - q->v[z];
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:613:34: warning: statement should be inside braces [readability-braces-
around-statements]
613 | for (int z = 0; z < f; z++)
| ^
| {
614 | node->v[z] /= norm;
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:627:18: warning: statement should be inside braces [readability-braces-
around-statements]
627 | if (dot != 0)
| ^
| {
628 | return (dot > 0);
629 | else
| }
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:629:9: warning: statement should be inside braces [readability-braces-
around-statements]
629 | else
| ^
| {
630 | return (bool)random.flip();
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:630:14: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
630 | return (bool)random.flip();
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:684:34: warning: C-style casts are discouraged; use static_cast [google-
readability-casting]
684 | return distance - (margin != (unsigned int) child_nr);
| ^~~~~~~~~~~~~~
| static_cast<unsigned int>( )
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:697:25: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
697 | v = v - ((v >> 1) & (T)~(T)0/3);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:697:29: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
697 | v = v - ((v >> 1) & (T)~(T)0/3);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:698:14: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
698 | v = (v & (T)~(T)0/15*3) + ((v >> 2) & (T)~(T)0/15*3);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:698:18: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
698 | v = (v & (T)~(T)0/15*3) + ((v >> 2) & (T)~(T)0/15*3);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:698:43: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
698 | v = (v & (T)~(T)0/15*3) + ((v >> 2) & (T)~(T)0/15*3);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:698:47: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
698 | v = (v & (T)~(T)0/15*3) + ((v >> 2) & (T)~(T)0/15*3);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:699:26: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
699 | v = (v + (v >> 4)) & (T)~(T)0/255*15;
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:699:30: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
699 | v = (v + (v >> 4)) & (T)~(T)0/255*15;
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:700:12: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
700 | return (T)(v * ((T)~(T)0/255)) >> (sizeof(T) - 1) * 8;
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:700:21: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
700 | return (T)(v * ((T)~(T)0/255)) >> (sizeof(T) - 1) * 8;
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:700:25: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
700 | return (T)(v * ((T)~(T)0/255)) >> (sizeof(T) - 1) * 8;
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:783:18: warning: statement should be inside braces [readability-braces-
around-statements]
783 | if (dot != 0)
| ^
| {
784 | return (dot > 0);
785 | else
| }
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:785:9: warning: statement should be inside braces [readability-braces-
around-statements]
785 | else
| ^
| {
786 | return (bool)random.flip();
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:786:14: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
786 | return (bool)random.flip();
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:790:23: warning: statement should be inside braces [readability-braces-
around-statements]
790 | if (child_nr == 0)
| ^
| {
791 | margin = -margin;
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:808:21: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
808 | Node<S, T>* p = (Node<S, T>*)alloca(s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:809:21: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
809 | Node<S, T>* q = (Node<S, T>*)alloca(s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:812:32: warning: statement should be inside braces [readability-braces-
around-statements]
812 | for (int z = 0; z < f; z++)
| ^
| {
813 | n->v[z] = p->v[z] - q->v[z];
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:816:32: warning: statement should be inside braces [readability-braces-
around-statements]
816 | for (int z = 0; z < f; z++)
| ^
| {
817 | n->a += -n->v[z] * (p->v[z] + q->v[z]) / 2;
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:841:21: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
841 | Node<S, T> *p = (Node<S, T> *)alloca(s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:842:21: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
842 | Node<S, T> *q = (Node<S, T> *)alloca(s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:846:32: warning: statement should be inside braces [readability-braces-
around-statements]
846 | for (int z = 0; z < f; z++)
| ^
| {
847 | n->v[z] = p->v[z] - q->v[z];
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:850:32: warning: statement should be inside braces [readability-braces-
around-statements]
850 | for (int z = 0; z < f; z++)
| ^
| {
851 | n->a += -n->v[z] * (p->v[z] + q->v[z]) / 2;
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:868:21: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
868 | Node<S, T>* p = (Node<S, T>*)alloca(s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:869:21: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
869 | Node<S, T>* q = (Node<S, T>*)alloca(s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:872:32: warning: statement should be inside braces [readability-braces-
around-statements]
872 | for (int z = 0; z < f; z++)
| ^
| {
873 | n->v[z] = p->v[z] - q->v[z];
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:876:32: warning: statement should be inside braces [readability-braces-
around-statements]
876 | for (int z = 0; z < f; z++)
| ^
| {
877 | n->a += -n->v[z] * (p->v[z] + q->v[z]) / 2;
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:895:11: warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
895 | virtual ~AnnoyIndexInterface() {};
| ^ ~~
| = default
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:896:58: warning: use nullptr [modernize-use-nullptr]
896 | virtual bool add_item(S item, const T* w, char** error=NULL) = 0;
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:897:60: warning: use nullptr [modernize-use-nullptr]
897 | virtual bool build(int q, int n_threads=-1, char** error=NULL) = 0;
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:898:37: warning: use nullptr [modernize-use-nullptr]
898 | virtual bool unbuild(char** error=NULL) = 0;
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:899:77: warning: use nullptr [modernize-use-nullptr]
899 | virtual bool save(const char* filename, bool prefault=false, char** error=NULL) = 0;
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:901:77: warning: use nullptr [modernize-use-nullptr]
901 | virtual bool load(const char* filename, bool prefault=false, char** error=NULL) = 0;
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:911:65: warning: use nullptr [modernize-use-nullptr]
911 | virtual bool on_disk_build(const char* filename, char** error=NULL) = 0;
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:930:3: warning: use 'using' instead of 'typedef' [modernize-use-using]
930 | typedef Distance D;
| ^~~~~~~~~~~~~~~~~~
| using D = Distance
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:931:3: warning: use 'using' instead of 'typedef' [modernize-use-using]
931 | typedef typename D::template Node<S, T> Node;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| using Node = typename D::template Node<S, T>
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:933:3: warning: use 'using' instead of 'typedef' [modernize-use-using]
933 | typedef typename std::remove_const<decltype(Random::default_seed)>::type R;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| using R = typename std::remove_const<decltype(Random::default_seed)>::type
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:955:4: warning: constructor does not initialize these fields: _nodes,
_loaded, _fd, _on_disk [cppcoreguidelines-pro-type-member-init]
942 | void* _nodes; // Could either be mmapped, or point to a memory buffer that we reallocate
|
| {}
943 | S _n_nodes;
944 | S _nodes_size;
945 | vector<S> _roots;
946 | S _K; // Max number of descendants to fit into node
947 | R _seed;
948 | bool _loaded;
|
| {}
949 | bool _verbose;
950 | int _fd;
|
| {}
951 | bool _on_disk;
|
| {}
952 | bool _built;
953 | public:
954 |
955 | AnnoyIndex(unsigned int f) : _f(f), _seed(Random::default_seed) {
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:959:10: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
959 | _K = (S) (((size_t) (_s - offsetof(Node, children))) / sizeof(S)); // Max number of descendants to fit into node
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:959:16: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
959 | _K = (S) (((size_t) (_s - offsetof(Node, children))) / sizeof(S)); // Max number of descendants to fit into node
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:962:3: warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
962 | ~AnnoyIndex() {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:970:8: warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
970 | bool add_item(S item, const T* w, char** error=NULL) {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:970:50: warning: use nullptr [modernize-use-nullptr]
970 | bool add_item(S item, const T* w, char** error=NULL) {
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:975:55: warning: use nullptr [modernize-use-nullptr]
975 | bool add_item_impl(S item, const W& w, char** error=NULL) {
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:981:26: warning: statement should be inside braces [readability-braces-
around-statements]
981 | if (item >= _n_items)
| ^
| {
982 | _n_items = item + 1;
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:992:42: warning: statement should be inside braces [readability-braces-
around-statements]
992 | for (unsigned int z = 0; z < _f; z++)
| ^
| {
993 | n->v[z] = w[z];
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1000:8: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1000 | bool on_disk_build(const char* file, char** error=NULL) {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1000:53: warning: use nullptr [modernize-use-nullptr]
1000 | bool on_disk_build(const char* file, char** error=NULL) {
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1003:50: warning: redundant cast to the same type [google-readability-
casting]
1003 | _fd = open(file, O_RDWR | O_CREAT | O_TRUNC, (int) 0600);
| ^~~~~
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1018:14: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1018 | _nodes = (Node*) mmap(0, _s * _nodes_size, PROT_READ | PROT_WRITE, MAP_SHARED | MAP_POPULATE, _fd, 0);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1018:27: warning: use nullptr [modernize-use-nullptr]
1018 | _nodes = (Node*) mmap(0, _s * _nodes_size, PROT_READ | PROT_WRITE, MAP_SHARED | MAP_POPULATE, _fd, 0);
| ^
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1025:8: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1025 | bool build(int q, int n_threads=-1, char** error=NULL) {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1025:52: warning: use nullptr [modernize-use-nullptr]
1025 | bool build(int q, int n_threads=-1, char** error=NULL) {
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1044:31: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1044 | _allocate_size(_n_nodes + (S)_roots.size());
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1045:47: warning: statement should be inside braces [readability-braces-
around-statements]
1045 | for (size_t i = 0; i < _roots.size(); i++)
| ^
| {
1046 | memcpy(_get(_n_nodes++), _get(_roots[i]), _s);
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1064:8: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1064 | bool unbuild(char** error=NULL) {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1064:29: warning: use nullptr [modernize-use-nullptr]
1064 | bool unbuild(char** error=NULL) {
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1077:8: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1077 | bool save(const char* filename, bool prefault=false, char** error=NULL) {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1077:69: warning: use nullptr [modernize-use-nullptr]
1077 | bool save(const char* filename, bool prefault=false, char** error=NULL) {
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1093:16: warning: use nullptr [modernize-use-nullptr]
1093 | if (f == NULL) {
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1098:46: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1098 | if (fwrite(_nodes, _s, _n_nodes, f) != (size_t) _n_nodes) {
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1115:14: warning: use nullptr [modernize-use-nullptr]
1115 | _nodes = NULL;
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1125:8: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1125 | void unload() {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1126:21: warning: implicit conversion 'int' -> 'bool' [readability-
implicit-bool-conversion]
1126 | if (_on_disk && _fd) {
| ^
| ( != 0)
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1134:11: warning: implicit conversion 'int' -> 'bool' [readability-
implicit-bool-conversion]
1134 | if (_fd) {
| ^
| != 0
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1142:18: warning: implicit conversion 'void *' -> 'bool' [readability-
implicit-bool-conversion]
1142 | } else if (_nodes) {
| ^
| != nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1151:8: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1151 | bool load(const char* filename, bool prefault=false, char** error=NULL) {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1151:69: warning: use nullptr [modernize-use-nullptr]
1151 | bool load(const char* filename, bool prefault=false, char** error=NULL) {
| ^~~~
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1153:36: warning: redundant cast to the same type [google-readability-
casting]
1153 | _fd = open(filename, O_RDONLY, (int)0400);
| ^~~~~
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1169:16: warning: implicit conversion 'size_t' (aka 'unsigned long') ->
'bool' [readability-implicit-bool-conversion]
1169 | } else if (size % _s) {
| ^
| ( ) != 0u
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1183:14: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1183 | _nodes = (Node*)mmap(0, size, PROT_READ, flags, _fd, 0);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1183:26: warning: use nullptr [modernize-use-nullptr]
1183 | _nodes = (Node*)mmap(0, size, PROT_READ, flags, _fd, 0);
| ^
| nullptr
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1184:16: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1184 | _n_nodes = (S)(size / _s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1188:11: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1188 | S m = (S)-1;
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1191:16: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1191 | if (m == (S)-1 || k == m) {
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1199:100: warning: statement should be inside braces [readability-braces-
around-statements]
1199 | if (_roots.size() > 1 && _get(_roots.front())->children[0] == _get(_roots.back())->children[0])
| ^
| {
1200 | _roots.pop_back();
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1208:5: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1208 | T get_distance(S i, S j) const {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1212:8: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1212 | void get_nns_by_item(S item, size_t n, int search_k, vector<S>* result, vector<T>* distances) const {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1218:8: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1218 | void get_nns_by_vector(const T* w, size_t n, int search_k, vector<S>* result, vector<T>* distances) const {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1222:5: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1222 | S get_n_items() const {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1226:5: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1226 | S get_n_trees() const {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1227:12: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1227 | return (S)_roots.size();
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1230:8: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1230 | void verbose(bool v) {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1234:8: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1234 | void get_item(S item, T* v) const {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1240:8: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1240 | void set_seed(R seed) {
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1244:5: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
1244 | R get_seed() const { return _seed; }
| ^
| override
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1251:12: warning: implicit conversion 'int' -> 'bool' [readability-
implicit-bool-conversion]
1251 | while (1) {
| ^
| true
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1260:36: warning: C-style casts are discouraged; use static_cast [google-
readability-casting]
1260 | if (thread_roots.size() >= (size_t)q) {
| ^~~~~~~~
| static_cast<size_t>( )
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1287:36: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1287 | S new_nodes_size = std::max(n, (S) ((_nodes_size + 1) * reallocation_factor));
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1298:14: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1298 | memset((char *) _nodes + (_nodes_size * _s) / sizeof(char), 0, (new_nodes_size - _nodes_size) * _s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1324:17: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1324 | double ls = (float)left_indices.size();
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1325:17: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1325 | double rs = (float)right_indices.size();
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1336:41: warning: statement should be inside braces [readability-braces-
around-statements]
1336 | if (indices.size() == 1 && !is_root)
| ^
| {
1337 | return indices[0];
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1339:27: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1339 | if (indices.size() <= (size_t)_K && (!is_root || (size_t)_n_items <= (size_t)_K || indices.size() == 1)) {
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1339:54: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1339 | if (indices.size() <= (size_t)_K && (!is_root || (size_t)_n_items <= (size_t)_K || indices.size() == 1)) {
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1339:74: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1339 | if (indices.size() <= (size_t)_K && (!is_root || (size_t)_n_items <= (size_t)_K || indices.size() == 1)) {
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1347:47: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1347 | m->n_descendants = is_root ? _n_items : (S)indices.size();
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1353:28: warning: statement should be inside braces [readability-braces-
around-statements]
1353 | if (!indices.empty())
| ^
| {
1354 | memcpy(m->children, &indices[0], indices.size() * sizeof(S));
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1365:13: warning: statement should be inside braces [readability-braces-
around-statements]
1365 | if (n)
| ^
| {
1366 | children.push_back(n);
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1370:15: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1370 | Node* m = (Node*)alloca(_s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1388:77: warning: statement should be inside braces [readability-braces-
around-statements]
1388 | if (_split_imbalance(children_indices[0], children_indices[1]) < 0.95)
| ^
| {
1389 | break;
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1403:44: warning: statement should be inside braces [readability-braces-
around-statements]
1403 | for (unsigned int z = 0; z < _f; z++)
| ^
| {
1404 | m->v[z] = 0;
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1415:45: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1415 | m->n_descendants = is_root ? _n_items : (S)indices.size();
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1434:20: warning: C-style casts are discouraged; use
static_cast/const_cast/reinterpret_cast [google-readability-casting]
1434 | Node* v_node = (Node *)alloca(_s);
| ^
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1450:25: warning: C-style casts are discouraged; use static_cast [google-
readability-casting]
1450 | while (nns.size() < (size_t)search_k && !q.empty()) {
| ^~~~~~~~
| static_cast<size_t>( )
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1475:21: warning: statement should be inside braces [readability-braces-
around-statements]
1475 | if (j == last)
| ^
| {
1476 | continue;
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1478:39: warning: statement should be inside braces [readability-braces-
around-statements]
1478 | if (_get(j)->n_descendants == 1) // This is only to guard a really obscure case, #284
| ^
| {
1479 | nns_dist.push_back(make_pair(D::distance(v_node, _get(j), _f), j));
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/annoylib.h:1486:21: warning: statement should be inside braces [readability-braces-
around-statements]
1486 | if (distances)
| ^
| {
1487 | distances->push_back(D::normalized_distance(nns_dist[i].first));
|
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/kissrandom.h:50:9: warning: C-style casts are discouraged; use static_cast [google-
readability-casting]
50 | z = (uint32_t) t;
| ^~~~~~~~~~
| static_cast<uint32_t>( )
/builds/acts/ci-bridge/src/build/_deps/annoy-build/include/annoy/kissrandom.h:100:10: warning: implicit conversion 'bool' -> 'uint64_t' (aka 'unsigned
long') [readability-implicit-bool-conversion]
100 | c += (x<t);
| ^
| static_cast<uint64_t>
[ninja] [1444/1452] Linking CXX executable bin/ActsUnitTestHashingSeedingTest
[ninja] [1445/1452] Building CXX object Tests/UnitTests/Plugins/EDM4hep/CMakeFiles/ActsUnitTestConvertTrackEDM4hep.dir/ConvertTrackEDM4hepTest.cpp.o
[ninja] [1446/1452] Linking CXX executable bin/ActsUnitTestConvertTrackEDM4hep
[ninja] [1447/1452] Building CXX object Tests/UnitTests/Plugins/Podio/CMakeFiles/ActsUnitTestPodioTrackContainer.dir/PodioTrackContainerTest.cpp.o
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/BoundParametersCollection.h:110:3: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
110 | ~BoundParametersCollection();
| ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/BoundParametersCollection.h:122:52: warning: C-style casts are discouraged; use static_cast (if
needed, the cast may be redundant) [google-readability-casting]
122 | BoundParametersCollection* operator->() { return (BoundParametersCollection*) this; }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| static_cast<BoundParametersCollection*>( )
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/BoundParametersObj.h:28:11: warning: prefer using 'override' or (rarely) 'final' instead of
'virtual' [modernize-use-override]
28 | virtual ~BoundParametersObj() = default;
| ~~~~~~~ ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/JacobianCollection.h:110:3: warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
110 | ~JacobianCollection();
| ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/JacobianCollection.h:122:45: warning: C-style casts are discouraged; use static_cast (if needed,
the cast may be redundant) [google-readability-casting]
122 | JacobianCollection* operator->() { return (JacobianCollection*) this; }
| ^~~~~~~~~~~~~~~~~~~~~
| static_cast<JacobianCollection*>( )
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/JacobianObj.h:28:11: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
28 | virtual ~JacobianObj() = default;
| ~~~~~~~ ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackCollection.h:110:3: warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
110 | ~TrackCollection();
| ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackCollection.h:122:42: warning: C-style casts are discouraged; use static_cast (if needed,
the cast may be redundant) [google-readability-casting]
122 | TrackCollection* operator->() { return (TrackCollection*) this; }
| ^~~~~~~~~~~~~~~~~~
| static_cast<TrackCollection*>( )
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackObj.h:28:11: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
28 | virtual ~TrackObj() = default;
| ~~~~~~~ ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackStateCollection.h:110:3: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
110 | ~TrackStateCollection();
| ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackStateCollection.h:122:47: warning: C-style casts are discouraged; use static_cast (if
needed, the cast may be redundant) [google-readability-casting]
122 | TrackStateCollection* operator->() { return (TrackStateCollection*) this; }
| ^~~~~~~~~~~~~~~~~~~~~~~
| static_cast<TrackStateCollection*>( )
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackStateObj.h:28:11: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
28 | virtual ~TrackStateObj() = default;
| ~~~~~~~ ^
| override
[ninja] [1448/1452] Linking CXX executable bin/ActsUnitTestPodioTrackContainer
[ninja] [1449/1452] Building CXX object
Tests/UnitTests/Plugins/Podio/CMakeFiles/ActsUnitTestPodioTrackStateContainer.dir/PodioTrackStateContainerTest.cpp.o
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/BoundParametersCollection.h:110:3: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
110 | ~BoundParametersCollection();
| ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/BoundParametersCollection.h:122:52: warning: C-style casts are discouraged; use static_cast (if
needed, the cast may be redundant) [google-readability-casting]
122 | BoundParametersCollection* operator->() { return (BoundParametersCollection*) this; }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| static_cast<BoundParametersCollection*>( )
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/BoundParametersObj.h:28:11: warning: prefer using 'override' or (rarely) 'final' instead of
'virtual' [modernize-use-override]
28 | virtual ~BoundParametersObj() = default;
| ~~~~~~~ ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/JacobianCollection.h:110:3: warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
110 | ~JacobianCollection();
| ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/JacobianCollection.h:122:45: warning: C-style casts are discouraged; use static_cast (if needed,
the cast may be redundant) [google-readability-casting]
122 | JacobianCollection* operator->() { return (JacobianCollection*) this; }
| ^~~~~~~~~~~~~~~~~~~~~
| static_cast<JacobianCollection*>( )
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/JacobianObj.h:28:11: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
28 | virtual ~JacobianObj() = default;
| ~~~~~~~ ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackCollection.h:110:3: warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
110 | ~TrackCollection();
| ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackCollection.h:122:42: warning: C-style casts are discouraged; use static_cast (if needed,
the cast may be redundant) [google-readability-casting]
122 | TrackCollection* operator->() { return (TrackCollection*) this; }
| ^~~~~~~~~~~~~~~~~~
| static_cast<TrackCollection*>( )
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackObj.h:28:11: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
28 | virtual ~TrackObj() = default;
| ~~~~~~~ ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackStateCollection.h:110:3: warning: annotate this function with 'override' or (rarely)
'final' [modernize-use-override]
110 | ~TrackStateCollection();
| ^
| override
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackStateCollection.h:122:47: warning: C-style casts are discouraged; use static_cast (if
needed, the cast may be redundant) [google-readability-casting]
122 | TrackStateCollection* operator->() { return (TrackStateCollection*) this; }
| ^~~~~~~~~~~~~~~~~~~~~~~
| static_cast<TrackStateCollection*>( )
/builds/acts/ci-bridge/src/Plugins/Podio/ActsPodioEdm/TrackStateObj.h:28:11: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
28 | virtual ~TrackStateObj() = default;
| ~~~~~~~ ^
| override
[ninja] [1450/1452] Linking CXX executable bin/ActsUnitTestPodioTrackStateContainer
[ninja] [1451/1452] Building CXX object Tests/UnitTests/Alignment/Kernel/CMakeFiles/ActsUnitTestAlignment.dir/AlignmentTests.cpp.o
[ninja] [1452/1452] Linking CXX executable bin/ActsUnitTestAlignment
/builds/acts/ci-bridge/src
rm: cannot remove '/builds/acts/ci-bridge/src/clang-tidy/clang-tidy.log': No such file or directory
$ python3 -m pip install -r CI/clang_tidy/requirements.txt
Collecting annotated-types==0.7.0 (from -r CI/clang_tidy/requirements.txt (line 7))
Downloading annotated_types-0.7.0-py3-none-any.whl.metadata (15 kB)
Collecting appdirs==1.4.4 (from -r CI/clang_tidy/requirements.txt (line 9))
Downloading appdirs-1.4.4-py2.py3-none-any.whl.metadata (9.0 kB)
Collecting codereport==0.4.0 (from -r CI/clang_tidy/requirements.txt (line 11))
Downloading codereport-0.4.0-py3-none-any.whl.metadata (709 bytes)
Collecting fs==2.4.16 (from -r CI/clang_tidy/requirements.txt (line 13))
Downloading fs-2.4.16-py2.py3-none-any.whl.metadata (6.3 kB)
Requirement already satisfied: jinja2==3.1.4 in /builds/acts/ci-bridge/venv/lib/python3.12/site-packages (from -r CI/clang_tidy/requirements.txt (line
15)) (3.1.4)
Collecting markdown-it-py==3.0.0 (from -r CI/clang_tidy/requirements.txt (line 17))
Downloading markdown_it_py-3.0.0-py3-none-any.whl.metadata (6.9 kB)
Requirement already satisfied: markupsafe==3.0.2 in /builds/acts/ci-bridge/venv/lib/python3.12/site-packages (from -r CI/clang_tidy/requirements.txt
(line 19)) (3.0.2)
Collecting mdurl==0.1.2 (from -r CI/clang_tidy/requirements.txt (line 21))
Downloading mdurl-0.1.2-py3-none-any.whl.metadata (1.6 kB)
Collecting pydantic==2.9.2 (from -r CI/clang_tidy/requirements.txt (line 23))
Downloading pydantic-2.9.2-py3-none-any.whl.metadata (149 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 149.4/149.4 kB 7.0 MB/s eta 0:00:00
Collecting pydantic-core==2.23.4 (from -r CI/clang_tidy/requirements.txt (line 25))
Downloading pydantic_core-2.23.4-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (6.6 kB)
Collecting pygments==2.18.0 (from -r CI/clang_tidy/requirements.txt (line 27))
Downloading pygments-2.18.0-py3-none-any.whl.metadata (2.5 kB)
Collecting python-slugify==6.1.2 (from -r CI/clang_tidy/requirements.txt (line 31))
Downloading python_slugify-6.1.2-py2.py3-none-any.whl.metadata (7.6 kB)
Requirement already satisfied: pyyaml==6.0.2 in /builds/acts/ci-bridge/venv/lib/python3.12/site-packages (from -r CI/clang_tidy/requirements.txt (line
33)) (6.0.2)
Collecting rich==13.9.4 (from -r CI/clang_tidy/requirements.txt (line 35))
Downloading rich-13.9.4-py3-none-any.whl.metadata (18 kB)
Collecting six==1.16.0 (from -r CI/clang_tidy/requirements.txt (line 37))
Downloading six-1.16.0-py2.py3-none-any.whl.metadata (1.8 kB)
Collecting text-unidecode==1.3 (from -r CI/clang_tidy/requirements.txt (line 39))
Downloading text_unidecode-1.3-py2.py3-none-any.whl.metadata (2.4 kB)
Collecting typing-extensions==4.12.2 (from -r CI/clang_tidy/requirements.txt (line 41))
Downloading typing_extensions-4.12.2-py3-none-any.whl.metadata (3.0 kB)
Collecting setuptools (from fs==2.4.16->-r CI/clang_tidy/requirements.txt (line 13))
Downloading setuptools-75.6.0-py3-none-any.whl.metadata (6.7 kB)
Downloading annotated_types-0.7.0-py3-none-any.whl (13 kB)
Downloading appdirs-1.4.4-py2.py3-none-any.whl (9.6 kB)
Downloading codereport-0.4.0-py3-none-any.whl (12 kB)
Downloading fs-2.4.16-py2.py3-none-any.whl (135 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 135.3/135.3 kB 24.1 MB/s eta 0:00:00
Downloading markdown_it_py-3.0.0-py3-none-any.whl (87 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 87.5/87.5 kB 27.9 MB/s eta 0:00:00
Downloading mdurl-0.1.2-py3-none-any.whl (10.0 kB)
Downloading pydantic-2.9.2-py3-none-any.whl (434 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 434.9/434.9 kB 31.9 MB/s eta 0:00:00
Downloading pydantic_core-2.23.4-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (2.1 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.1/2.1 MB 93.2 MB/s eta 0:00:00
Downloading pygments-2.18.0-py3-none-any.whl (1.2 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.2/1.2 MB 85.3 MB/s eta 0:00:00
Downloading python_slugify-6.1.2-py2.py3-none-any.whl (9.4 kB)
Downloading rich-13.9.4-py3-none-any.whl (242 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 242.4/242.4 kB 57.9 MB/s eta 0:00:00
Downloading six-1.16.0-py2.py3-none-any.whl (11 kB)
Downloading text_unidecode-1.3-py2.py3-none-any.whl (78 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 78.2/78.2 kB 22.5 MB/s eta 0:00:00
Downloading typing_extensions-4.12.2-py3-none-any.whl (37 kB)
Downloading setuptools-75.6.0-py3-none-any.whl (1.2 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.2/1.2 MB 100.8 MB/s eta 0:00:00
Installing collected packages: text-unidecode, appdirs, typing-extensions, six, setuptools, python-slugify, pygments, mdurl, annotated-types,
pydantic-core, markdown-it-py, fs, rich, pydantic, codereport
Successfully installed annotated-types-0.7.0 appdirs-1.4.4 codereport-0.4.0 fs-2.4.16 markdown-it-py-3.0.0 mdurl-0.1.2 pydantic-2.9.2 pydantic-
core-2.23.4 pygments-2.18.0 python-slugify-6.1.2 rich-13.9.4 setuptools-75.6.0 six-1.16.0 text-unidecode-1.3 typing-extensions-4.12.2
[notice] A new release of pip is available: 24.0 -> 24.3.1
[notice] To update, run: pip install --upgrade pip
$ CI/clang_tidy/parse_clang_tidy.py clang-tidy/clang-tidy.log clang-tidy/clang-tidy.json --exclude "*thirdparty*" --exclude "*ActsPodioEdm*" --exclude
"*build/_deps/*"
Write to clang-tidy/clang-tidy.json
$ CI/clang_tidy/check_clang_tidy.py --report clang-tidy/clang-tidy.json --config CI/clang_tidy/limits.yml
────────────────────────────────────────────────────────────────────────────────
╭────────────────────────────────── Results ───────────────────────────────────╮
│ ┏━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━┳━━━━━━━┓ │
│ ┃ ┃ code / pattern ┃ count ┃ limit ┃ │
│ ┡━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━╇━━━━━━━┩ │
│ │ 🟢 │ clang-analyzer-optin.cplusplus.UninitializedObject │ 0 │ 0 │ │
│ │ 🟢 │ clang-diagnostic-error │ 0 │ 0 │ │
│ │ 🟢 │ cppcoreguidelines-init-variables │ 0 │ 0 │ │
│ │ 🟢 │ cppcoreguidelines-pro-type-member-init │ 0 │ 0 │ │
│ │ 🟢 │ google-readability-casting │ 0 │ 0 │ │
│ │ 🟢 │ modernize-concat-nested-namespaces │ 0 │ 0 │ │
│ │ 🟢 │ modernize-use-equals-default │ 0 │ 0 │ │
│ │ 🟢 │ modernize-use-default-member-init │ 0 │ 0 │ │
│ │ 🟢 │ modernize-use-nullptr │ 0 │ 0 │ │
│ │ 🟢 │ modernize-use-override │ 0 │ 0 │ │
│ │ 🟢 │ modernize-use-using │ 0 │ 0 │ │
│ │ 🟢 │ performance-for-range-copy │ 0 │ 0 │ │
│ │ 🟢 │ performance-move-const-arg │ 0 │ 0 │ │
│ │ 🟢 │ performance-unnecessary-value-param │ 0 │ 0 │ │
│ │ 🟢 │ readability-braces-around-statements │ 0 │ 0 │ │
│ │ 🟢 │ readability-container-size-empty │ 0 │
Loading