Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workaround Pythia8 race condition in ttbar physmon #3965

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Dec 7, 2024

Until #3963 is fixed we have to stick to single threaded processing with ttbar

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted threading configuration to single-threaded execution to enhance stability and prevent race conditions during simulations.

@andiwand andiwand added this to the next milestone Dec 7, 2024
Copy link

coderabbitai bot commented Dec 7, 2024

Walkthrough

Change made, yes. In the physmon_trackfinding_ttbar_pu200.py script, the numThreads parameter of the acts.examples.Sequencer modified it is. From -1 to 1 it shifts, single-threaded execution now it allows. Prevent race conditions with Pythia8, this aims. Control flow altered, stability enhanced during execution, yes.

Changes

File Path Change Summary
CI/physmon/workflows/physmon_trackfinding_ttbar_pu200.py numThreads changed from -1 to 1 for single-threaded execution.

Poem

In threads we once did race,
Now single, we embrace.
Stability in our quest,
Pythia8, we shall best!
A change so small, yet grand,
Together, we will stand! 🌌✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Dec 7, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
CI/physmon/workflows/physmon_trackfinding_ttbar_pu200.py (1)

38-41: Monitor performance impact, you should. Hmmmm.

Single-threaded execution, slower it may be. Until permanent fix arrives, these steps take:

  • Measure and document performance impact
  • Consider adding configuration flag for threading mode
  • Monitor memory usage patterns

Help create performance monitoring instrumentation, shall I? Open GitHub issue to track metrics, we can.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5e8efd6 and a6c7559.

📒 Files selected for processing (1)
  • CI/physmon/workflows/physmon_trackfinding_ttbar_pu200.py (1 hunks)

Copy link

github-actions bot commented Dec 7, 2024

📊: Physics performance monitoring for a382e1a

Full contents

physmon summary

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love it, but seems like we don't have another way for now.

Copy link

sonarqubecloud bot commented Dec 9, 2024

@kodiakhq kodiakhq bot merged commit 94ae506 into acts-project:main Dec 9, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Dec 9, 2024
@andiwand andiwand deleted the fix-physmon-ttbar-racecondition branch December 9, 2024 13:22
@paulgessinger paulgessinger modified the milestones: next, v38.2.0 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants