-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Workaround Pythia8 race condition in ttbar physmon #3965
fix: Workaround Pythia8 race condition in ttbar physmon #3965
Conversation
WalkthroughChange made, yes. In the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
CI/physmon/workflows/physmon_trackfinding_ttbar_pu200.py (1)
38-41
: Monitor performance impact, you should. Hmmmm.Single-threaded execution, slower it may be. Until permanent fix arrives, these steps take:
- Measure and document performance impact
- Consider adding configuration flag for threading mode
- Monitor memory usage patterns
Help create performance monitoring instrumentation, shall I? Open GitHub issue to track metrics, we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love it, but seems like we don't have another way for now.
Quality Gate passedIssues Measures |
Until #3963 is fixed we have to stick to single threaded processing with ttbar
Summary by CodeRabbit