-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Split particle selection in Examples #3969
base: main
Are you sure you want to change the base?
Conversation
andiwand
commented
Dec 9, 2024
- split particle selection into three stages: after generation, after simulation, after digitization
- this allows to perform cuts on the particle collections independent from the algorithms processing them
- after digitization cuts allow to cut on measurement count
- elevates particle selection into reconstruction chain
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -726,6 +654,37 @@ def addGeant4( | |||
return s | |||
|
|||
|
|||
def addSimParticleSelection( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is quite a lot of code duplication. I would put this in a single function with a string argument, and then maybe add an abstraction interface
def addParticleSelection(..., kind="simulated" #or "digitized"):
# impl...
def addSimParticleSelection(*args, **kwargs):
return addParticleSelection(*args, "simulated", **kwargs)
def addDigiParticleSelection(*args, **kwargs):
return addParticleSelection(*args, "digitized", **kwargs)
or similar.
Would also be fine leaving this to the user totally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point. This would also remove the cryptic short names Gen
, Sim
, Digi
Quality Gate passedIssues Measures |