refactor: Combine GSF actor and aborter #3984
Conversation
WalkthroughChanges to the Gaussian Sum Fitter, there are. Removed, the Changes
Possibly related PRs
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Core/include/Acts/TrackFitting/detail/GsfActor.hpp (2)
535-537: Documentation for geo context usage, suggest I do.Help future Padawans understand the ways of the Force, a comment about geo context usage would. The code itself, correct it is.
+ // Use stepping's geo context for bound to free transformation cmp.jacToGlobal() = surface.boundToFreeJacobian( state.stepping.geoContext, freeParams.template segment<3>(eFreePos0), freeParams.template segment<3>(eFreeDir0));
Line range hint
1-824: Wise architectural changes, these are.Improved encapsulation through internal abort handling, I sense. Clean separation of concerns, maintained it is. The Dark Side of external dependencies, reduced it has been.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Core/include/Acts/TrackFitting/detail/GsfActor.hpp(2 hunks)
🔇 Additional comments (1)
Core/include/Acts/TrackFitting/detail/GsfActor.hpp (1)
322-333: Clean and focused, this new method is, hmmmm.
Well-implemented function for navigation control, I see. Proper logging and clear purpose, it has. The Force is strong with this code.
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
Core/include/Acts/TrackFitting/detail/GsfActor.hpp (1)
Inconsistent usage of geoContext in GsfActor.hpp, I sense.
In GsfActor.hpp, three instances of
state.stepping.geoContextstill remain, while other files have embracedstate.options.geoContext. Harmonize these patterns, we must:
- Line references in GsfActor.hpp:
old_bound.position(state.stepping.geoContext), state.options.directionstate.stepping.geoContextold_bound.position(state.stepping.geoContext), old_bound.direction()🔗 Analysis chain
Line range hint
1-320: Verify the geo context changes across the codebase, we must.Replaced
state.stepping.geoContextwithstate.options.geoContext, I see. Ensure consistency across all usages, we should.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining instances of stepping.geoContext rg "stepping\.geoContext" # Search for new pattern to verify consistency rg "options\.geoContext"Length of output: 1755
🧹 Nitpick comments (1)
Core/include/Acts/TrackFitting/detail/GsfActor.hpp (1)
322-333: Improved encapsulation, this refactoring brings.Moving abort logic into GsfActor, better design it is. Single Responsibility Principle, it now follows. No longer does it depend on NavigationBreakAborter, hmm.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Core/include/Acts/TrackFitting/detail/GsfActor.hpp(1 hunks)
🔇 Additional comments (1)
Core/include/Acts/TrackFitting/detail/GsfActor.hpp (1)
322-333: Clean and focused, this implementation is!
Well-implemented abort check, with clear purpose and good logging, I see. Single responsibility principle, it follows.
|
Currently the GSF actor communicates the abort flag via the navigation break which is not ideal. I want to remove setting this flag from outside in #3449. The GSF can carry this flag by itself and after the actor+aborter refactor we do not need a separate aborter anymore.
pulled out of #3449
Summary by CodeRabbit
NavigationBreakAborterstruct.