Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Output correct track objects in GSF refitting #3999

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: Output correct track objects in GSF refitting #3999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
30d4564
update
benjaminhuth Dec 19, 2024
52ed96f
update
benjaminhuth Dec 19, 2024
abd3155
update
benjaminhuth Dec 19, 2024
262c153
update
benjaminhuth Dec 19, 2024
3e34e7e
revert cov inflation, fix kf outputs
benjaminhuth Dec 19, 2024
26fbffa
update hashes
benjaminhuth Dec 19, 2024
b84b2cd
Merge branch 'main' into fix/gsf-refit-wrong-outputs
kodiakhq[bot] Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified CI/physmon/reference/trackrefitting_gsf/performance_trackrefitting.root
View file
Open in desktop
Binary file not shown.
Binary file modified CI/physmon/reference/trackrefitting_kf/performance_trackrefitting.root
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions Examples/Python/tests/root_file_hashes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ test_exatrkx[gpu-onnx]__performance_track_finding.root: 9090de10ffb1489d3f1993e2
test_exatrkx[gpu-torch]__performance_track_finding.root: 6b658fa22c7532e082eaab7aa4b71b852f1c324adcc59d1156aff45124b222d9
test_ML_Ambiguity_Solver__performance_finding_ambiML.root: 166dd8bb189097c4957b7b02c04c41267868d72d9a08c4bb892985b06849cb76
test_refitting[odd]__trackstates_gsf_refit.root: e297749dc1e7eda3b8dea13defa0499986c584740d93e723a901b498b8e90c71
test_refitting[odd]__tracksummary_gsf_refit.root: d5085882e45a0b699194dff9f40a36e9291227bf65f9aaaf9087f9242ef5ae22
test_refitting[odd]__tracksummary_gsf_refit.root: 1f1bec7c55071cd077fdfaaa813e9a5fe56d1c0b01f1b33ace2a9f28be2c26de
test_refitting[generic]__trackstates_gsf_refit.root: 4424fdf2f27575db825c1a59f8e53a1595946211cbd5b2c8d3a2f71cdcc77ae9
test_refitting[generic]__tracksummary_gsf_refit.root: 562deecee4cfb97ceee72eff53d63da079e3249fb62d6bcd556e6f27d495dfd9
test_refitting[generic]__tracksummary_gsf_refit.root: 5e9402ce33807815e2470760b66a32d1cd88de44501ec415480f3f1240960e4a
test_truth_tracking_kalman[generic-0.0]__trackstates_kf.root: 9f77962b92037cb760b1629a602b1dae61f45e659c45d9a87baa784f6190960e
test_truth_tracking_kalman[generic-0.0]__tracksummary_kf.root: 562deecee4cfb97ceee72eff53d63da079e3249fb62d6bcd556e6f27d495dfd9
test_truth_tracking_kalman[generic-1000.0]__trackstates_kf.root: 56a1bd989b9c1316b9098c65fa75df9e6683e62e35ae68d8f72d27220be0fd7d
Expand Down
6 changes: 3 additions & 3 deletions Examples/Scripts/Python/truth_tracking_gsf_refitting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def runRefittingGsf(
s.addWriter(
acts.examples.RootTrackSummaryWriter(
level=acts.logging.INFO,
inputTracks="tracks",
inputTracks="gsf_refit_tracks",
inputParticles="particles_selected",
inputTrackParticleMatching="refit_track_particle_matching",
filePath=str(outputDir / "tracksummary_gsf_refit.root"),
Expand All @@ -86,9 +86,9 @@ def runRefittingGsf(
s.addWriter(
acts.examples.TrackFitterPerformanceWriter(
level=acts.logging.INFO,
inputTracks="tracks",
inputTracks="gsf_refit_tracks",
inputParticles="particles_selected",
inputTrackParticleMatching="track_particle_matching",
inputTrackParticleMatching="refit_track_particle_matching",
filePath=str(outputDir / "performance_gsf_refit.root"),
)
)
Expand Down
6 changes: 3 additions & 3 deletions Examples/Scripts/Python/truth_tracking_kalman_refitting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def runRefittingKf(
s.addWriter(
acts.examples.RootTrackSummaryWriter(
level=acts.logging.INFO,
inputTracks="tracks",
inputTracks="kf_refit_tracks",
inputParticles="particles_selected",
inputTrackParticleMatching="refit_track_particle_matching",
filePath=str(outputDir / "tracksummary_kf_refit.root"),
Expand All @@ -83,9 +83,9 @@ def runRefittingKf(
s.addWriter(
acts.examples.TrackFitterPerformanceWriter(
level=acts.logging.INFO,
inputTracks="tracks",
inputTracks="kf_refit_tracks",
inputParticles="particles_selected",
inputTrackParticleMatching="track_particle_matching",
inputTrackParticleMatching="refit_track_particle_matching",
filePath=str(outputDir / "performance_kf_refit.root"),
)
)
Expand Down
Loading