Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "ci: Use CERN registry cache in GitLab CI" #4022

Merged

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Jan 13, 2025

This reverts commit 494bbb8.

CERN Harbor has a 1/2 day maintenance window going on: https://cern.service-now.com/service-portal?id=outage&n=OTG0153808

PLEASE DESCRIBE YOUR CHANGES.
THIS MESSAGE ENDS UP AS THE COMMIT MESSAGE.
DO NOT USE @-MENTIONS HERE!

--- END COMMIT MESSAGE ---

Any further description goes here, @-mentions are ok here!

  • Use a conventional commits prefix: quick summary
    • We mostly use feat, fix, refactor, docs, chore and build types.
  • A milestone will be assigned by one of the maintainers

Summary by CodeRabbit

  • Chores
    • Updated Docker image references in CI/CD pipeline configuration
    • Simplified image paths across multiple jobs
    • Removed registry.cern.ch/ prefix from image references
    • No functional changes to the CI/CD pipeline

Copy link

coderabbitai bot commented Jan 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Hmm, a subtle change in the GitLab CI configuration, this is. Docker image references, simplified they have been. From the lengthy registry.cern.ch/ghcr.io/acts-project/... path, to the more concise ghcr.io/acts-project/..., transformed they are. Across multiple jobs - from build to test, consistent the modification remains. No functional alterations, there are. A clean, streamlined path to continuous integration, we now walk.

Changes

File Change Summary
.gitlab-ci.yml Image references updated across multiple jobs, removing registry.cern.ch/ prefix from Docker image paths

Suggested labels

automerge

Suggested reviewers

  • AJPfleger
  • andiwand

Possibly related PRs

Poem

Paths of code, simplified they are
Docker images, no longer from afar
CI pipeline, clean and bright 🚀
Registry prefix, now takes flight ✨
Yoda's wisdom, in config we see! 🧘‍♂️


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d51b7b7 and 4923f0f.

📒 Files selected for processing (1)
  • .gitlab-ci.yml (9 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@paulgessinger paulgessinger changed the title Revert "ci: Use CERN registry cache in GitLab CI" revert: "ci: Use CERN registry cache in GitLab CI" Jan 13, 2025
@github-actions github-actions bot added this to the next milestone Jan 13, 2025
@paulgessinger paulgessinger merged commit bc035b1 into acts-project:main Jan 13, 2025
20 of 39 checks passed
@paulgessinger paulgessinger deleted the ci/drop-cern-reg-proxy branch January 13, 2025 08:20
Copy link

📊: Physics performance monitoring for 4923f0f

Full contents

physmon summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants