refactor: Add back DD4hep field access #4073
Conversation
This was removed in acts-project#3498, but we do need it.
WalkthroughA new public method, Changes
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Examples/Detectors/DD4hepDetector/include/ActsExamples/DD4hepDetector/DD4hepDetector.hpp (1)
91-93: Documentation enhancement, beneficial it would be.While documentation exists, more details about return value ownership and potential exceptions, helpful they would be.
/// @brief Access to the DD4hep field +/// @return A shared pointer to the DD4hep field adapter, ownership shared it is +/// @throws std::runtime_error if field access fails std::shared_ptr<Acts::DD4hepFieldAdapter> field() const;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
Examples/Detectors/DD4hepDetector/include/ActsExamples/DD4hepDetector/DD4hepDetector.hpp(2 hunks)Examples/Detectors/DD4hepDetector/src/DD4hepDetector.cpp(1 hunks)Examples/Python/src/DD4hepComponent.cpp(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: CI Bridge / clang_tidy
- GitHub Check: merge-sentinel
- GitHub Check: unused_files
- GitHub Check: missing_includes
- GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, clang++)
- GitHub Check: macos
- GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, g++)
- GitHub Check: build_debug
- GitHub Check: docs
- GitHub Check: linux_ubuntu
🔇 Additional comments (3)
Examples/Detectors/DD4hepDetector/include/ActsExamples/DD4hepDetector/DD4hepDetector.hpp (1)
31-33: Forward declaration, well placed it is.Clean and proper forward declaration of DD4hepFieldAdapter class in Acts namespace, I see.
Examples/Python/src/DD4hepComponent.cpp (2)
40-41: Python bindings, well structured they are.Clean addition of read-only field property to Python bindings, I observe. Proper exposure of DD4hep field functionality to Python users, this provides.
63-66: Field adapter binding, complete it appears.Proper exposure of DD4hepFieldAdapter to Python, maintaining inheritance from MagneticFieldProvider, I see.
|
@andiwand forward declaration doesn't seem to be working, can you go again? |
|
This was removed in #3498, but we do need it.
--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.Summary by CodeRabbit