build: Use CONFIG mode for onnxruntime #4086
Conversation
WalkthroughModified, the CMake configuration has been. Changed, the find_package command now uses Changes
Sequence Diagram(s)sequenceDiagram
participant CMake as CMake Build
participant Config as OnnxRuntime Config
participant Target as ActsPluginOnnx
CMake->>Config: find_package(onnxruntime CONFIG REQUIRED)
Config-->>CMake: Provide configuration details
CMake->>Target: Link target with onnxruntime::onnxruntime
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
Infrastructure
|
@benjaminhuth @Corentin-Allaire I don't fully know if this will work as is, I only tested with spack. |
I can test it with cmake tomorrow morning if you want |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
CMakeLists.txt(1 hunks)Plugins/Onnx/CMakeLists.txt(1 hunks)Plugins/Onnx/include/Acts/Plugins/Onnx/OnnxRuntimeBase.hpp(1 hunks)Plugins/Onnx/include/Acts/Plugins/Onnx/SeedClassifier.hpp(1 hunks)cmake/FindOnnxRuntime.cmake(0 hunks)
💤 Files with no reviewable changes (1)
- cmake/FindOnnxRuntime.cmake
✅ Files skipped from review due to trivial changes (2)
- Plugins/Onnx/include/Acts/Plugins/Onnx/OnnxRuntimeBase.hpp
- Plugins/Onnx/include/Acts/Plugins/Onnx/SeedClassifier.hpp
⏰ Context from checks skipped due to timeout of 90000ms (21)
- GitHub Check: merge-sentinel
- GitHub Check: CI Bridge / lcg_106a: [alma9, clang16]
- GitHub Check: CI Bridge / lcg_105: [alma9, clang16]
- GitHub Check: CI Bridge / lcg_106a: [alma9, gcc14]
- GitHub Check: CI Bridge / lcg_105: [alma9, gcc13]
- GitHub Check: CI Bridge / lcg_106a: [alma9, gcc13]
- GitHub Check: CI Bridge / clang_tidy
- GitHub Check: CI Bridge / build_exatrkx_cpu
- GitHub Check: CI Bridge / build_linux_ubuntu
- GitHub Check: CI Bridge / linux_ubuntu_2204_clang
- GitHub Check: CI Bridge / linux_ubuntu_2204
- GitHub Check: CI Bridge / build_exatrkx
- GitHub Check: unused_files
- GitHub Check: missing_includes
- GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, clang++)
- GitHub Check: CI Bridge / build_gnn_tensorrt
- GitHub Check: macos
- GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, g++)
- GitHub Check: build_debug
- GitHub Check: linux_ubuntu
- GitHub Check: docs
🔇 Additional comments (1)
Plugins/Onnx/CMakeLists.txt (1)
21-21: Correct, this change is! Modern CMake practices, it follows!The namespaced target
onnxruntime::onnxruntimealigns with CONFIG mode and modern CMake best practices.
|
I don't have much of an opinion, since the ONNX version of the pipeline is not to well maintained at the moment. |
It works as is on my machine |
|
@Corentin-Allaire Brilliant! Can you approve this one? |
|
acts-project-service
added
the
Fails Athena tests
Switch to using CMake's CONFIG mode for finding ONNX. This also deletes the find module we ship as of now.
--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.Summary by CodeRabbit