ci: Add LCG 107a builds #4091
ci: Add LCG 107a builds #4091
Conversation
WalkthroughA new job Changes
Sequence Diagram(s)sequenceDiagram
participant P as Pipeline
participant R as CI Runner
participant J as Job lcg_107
P->>R: Trigger pipeline execution
R->>J: Initialize job from .lcg_base_job
J->>J: Execute parallel matrix (alma9 with gcc13, gcc14, clang19)
J->>P: Return job results
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.gitlab-ci.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: merge-sentinel
- GitHub Check: unused_files
- GitHub Check: missing_includes
- GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, clang++)
- GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, g++)
- GitHub Check: linux_ubuntu
- GitHub Check: macos
- GitHub Check: build_debug
🔇 Additional comments (1)
.gitlab-ci.yml (1)
509-513: Notice a pattern in compiler progression, I do!Wise choice of compilers, this is. Upgraded from LCG 106a's gcc13, gcc14, clang16 to gcc13, gcc14, clang19 in LCG 107, maintaining compatibility while embracing newer tools.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CMakePresets.json (1)
105-112: New Preset "gitlab-ci-lcg" Added, It Has Been!
A new preset for LCG builds, you introduce. Useful for configuring LCG version builds, it is indeed. However, check the indentations on line 110 carefully, you must. Consistency in formatting, important it is for readability and maintenance. Consider aligning the indent with its sibling properties for better clarity, you should.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.gitlab-ci.yml(2 hunks)CMakePresets.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .gitlab-ci.yml
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: merge-sentinel
- GitHub Check: CI Bridge / lcg_106a: [alma9, gcc14]
- GitHub Check: CI Bridge / lcg_106a: [alma9, gcc13]
- GitHub Check: CI Bridge / lcg_105: [alma9, clang16]
- GitHub Check: CI Bridge / lcg_105: [alma9, gcc13]
- GitHub Check: CI Bridge / linux_ubuntu_2204_clang
- GitHub Check: CI Bridge / linux_ubuntu_2204
- GitHub Check: CI Bridge / build_linux_ubuntu
- GitHub Check: CI Bridge / build_exatrkx_cpu
- GitHub Check: CI Bridge / build_exatrkx
- GitHub Check: CI Bridge / build_exatrkx_cpu
- GitHub Check: CI Bridge / clang_tidy
- GitHub Check: macos
🔇 Additional comments (1)
CMakePresets.json (1)
96-104: Refined Display Name for clang-tidy Preset, It Is!
A clear change you made, updating the display name to "GitLab-CI clang-tidy". Improved clarity for team members this brings. Approved, it is.
github-actions
bot
added
Component - Core
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Plugins/Json/src/DetrayJsonHelper.cpp (1)
9-14: Track this temporary workaround, we must.Hmmmm, a temporary solution for GCC 13, this is. Create an issue to track and revisit this workaround in the future, we should. When resolved upstream, this bypass must be removed.
Help you create a tracking issue for this GCC 13 workaround, shall I?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.gitlab-ci.yml(2 hunks)CMakePresets.json(1 hunks)Plugins/Json/src/DetrayJsonHelper.cpp(2 hunks)Tests/UnitTests/Core/MagneticField/MultiRangeBFieldTests.cpp(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- Tests/UnitTests/Core/MagneticField/MultiRangeBFieldTests.cpp
🚧 Files skipped from review as they are similar to previous changes (2)
- .gitlab-ci.yml
- CMakePresets.json
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: merge-sentinel
- GitHub Check: linux_ubuntu
- GitHub Check: macos
🔇 Additional comments (1)
Plugins/Json/src/DetrayJsonHelper.cpp (1)
22-24: Approve these changes, I do. Safer bounds checking, they bring.Wise changes these are, using
.at()for vector access andstd::vector{}for initialization. Protection against the dark side of buffer overflows, they provide.Also applies to: 29-29, 40-41, 44-45, 50-51
|
acts-project-service
added
the
Fails Athena tests
--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.Summary by CodeRabbit