Benchmarks Fix, main branch (2023.03.29.) #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the same time enabled the build of benchmarks in the CI. In case we ever add some to the project...
|
I think it is best to be reviewed by @niermann999 |
|
To make it clear: If you currently use This is how I discovered this issue. By trying to make sure that all parts of the code would be compiled for another development that I'm working on at the moment. |
|
Benchmarks are added in #95 and the |
niermann999
approved these changes
Mar 29, 2023
|
That does paint it in a slightly different light, but let's just add back the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the reference to the non-existent
benchmarks/directory. This was introduced in #69, which I just really don't see the point in now that I look back. 😦 (One would only add Google Benchmark in the PR in which it is first needed. And touching all those files without a need is just pretty bad... 😦)At the same time enabled the "build of benchmarks" in the CI. In case we ever add some to the project...